Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code

[Max Nikulin]

Rudolf, I am afraid there is another obstacle till your step to improve 
Org may be completed.

On 07/02/2023 15:39, Rudolf Adamkovič wrote:
> -            (let* ((input-file
> -                    (make-temp-file "test" nil ".info"))
> -                   (input-content
> -                    (concat (format "@setfilename %s" input-file) "\n"
> -                            "@node Top" "\n"
> -                            (format "@displaymath{%s}" math-example) "\n")))
> +            (let* ((input-file (make-temp-file "test" nil ".info"))
> +                   (input-content (string-join

In emacs-26 `string-join' is defined in subr-x.el, but ox-texinfo.el 
does not have (require 'subr-x). Personally I see nothing bad in

   (format "@displaymath\n%s\n@end" math-example)

Historically subr-x was avoided in Org. Latest discussion:
https://list.orgmode.org/b1eef17f-b8ef-2e2a-d463-7909b03ce6eb@gmail.com/T/#u
[BUG] Re: 98e168b48 Add compatibility wrapper for 
string-clean-whitespace (Emacs 26 compatibility) Fri, 07 Oct 2022 
13:14:11 +0800

I will leave the decision to the maintainers since I have no particular 
opinion. Alternatively you may use (mapconcat #'identity (list) "\n").

It is preferable to fix earlier added call to `string-join' in this 
file. The similar approach should be applied to the tests added by this 
patch.

> +                                   (list (format "@setfilename %s" input-file)
> +                                         "@node Top"
> +                                         "@displaymath"