emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] org-babel-insert-result: Fix wrong-type-argument markerp nil


From: Ihor Radchenko
Subject: Re: [PATCH] org-babel-insert-result: Fix wrong-type-argument markerp nil
Date: Wed, 09 Nov 2022 02:33:02 +0000

Bruno Barbier <perso.bruno.barbier@free.fr> writes:

> Here is a small patch for a corner case in `org-babel-insert-result'.

Thanks, but could you please explain a bit more about this corner case?

> lisp/ob-core.el (org-babel-insert-result): Don't reset the marker
> `end' if it is not defined.

`end' must be always defined because
(setq end (copy-marker (point) t))
must be executed.

Nothing must ever set `end' to nil. Otherwise, a couple of other places
in code will also be broken.

Your patch, if addressing a valid scenario, is not treating the root
cause; just the symptom.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]