[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2-v1] New: auto display inline images under subtree when `org-cyc
From: |
Christopher M. Miles |
Subject: |
[PATCH 2-v1] New: auto display inline images under subtree when `org-cycle'. |
Date: |
Wed, 28 Sep 2022 20:55:00 +0800 |
User-agent: |
mu4e 1.8.9; emacs 29.0.50 |
Ok, I created the patch for subtree cycling display inline images.
Tested by edebug when org cycling, it should works fine. I don't know
how to write test for this.
But I got a little problem:
When ~org-fold-core-style~ is ~'overlays~, the ~delete-overlay~ will
cause subtree unfolded. More detailed check out the "org.el" function
~org-remove-inline-images~ in my patch.
0001-org.el-Support-auto-display-inline-images-when-cycli.patch
Description: Text Data
Ihor Radchenko <yantar92@gmail.com> writes:
> "Christopher M. Miles" <numbchild@gmail.com> writes:
>
>> I checked out your patch, it's fine to me. Should be fine to apply.
>
> Done.
> Applied onto main.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=95df82c5fcf926088da2aaab9354a902956ae881
>
> Going back to cycling inline image visibility now.
>
> I think that the first step should be extending
> `org-remove-inline-images' and `org-display-inline-images' to work on
> regions. `org-display-inline-images' already provides BEG and END
> optional arguments, but it currently clears all the images in buffer
> unconditionally.
>
> We will need to make `org-remove-inline-images' work on region and
> modify `org-display-inline-images' to not affect images outside the
> provided region.
>
> Then, we can modify `org-toggle-inline-images' accordingly and make use
> of it in org-cycle.el to toggle images in section/subtree.
--
[ stardiviner ]
I try to make every word tell the meaning that I want to express without
misunderstanding.
Blog: https://stardiviner.github.io/
IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
signature.asc
Description: PGP signature
- Re: [PATCH] New: auto display inline images under subtree when `org-cycle'., (continued)
- Message not available
- Message not available
- Re: [PATCH 3] New: auto display inline images under subtree when `org-cycle'., Ihor Radchenko, 2022/09/14
- [PATCH 4] New: auto display inline images under subtree when `org-cycle'., Christopher M. Miles, 2022/09/15
- Message not available
- Re: [PATCH 4] New: auto display inline images under subtree when `org-cycle'., Ihor Radchenko, 2022/09/15
- [PATCH 5] New: auto display inline images under subtree when `org-cycle'., Christopher M. Miles, 2022/09/15
- Message not available
- [PATCH v6] Re: [PATCH 5] New: auto display inline images under subtree when `org-cycle'., Ihor Radchenko, 2022/09/20
- Re: [PATCH v6] New: auto display inline images under subtree when `org-cycle'., Christopher M. Miles, 2022/09/20
- Message not available
- Re: [PATCH v6] New: auto display inline images under subtree when `org-cycle'., Ihor Radchenko, 2022/09/21
- [PATCH 2-v1] New: auto display inline images under subtree when `org-cycle'.,
Christopher M. Miles <=
- Message not available
- Re: [PATCH 2-v1] New: auto display inline images under subtree when `org-cycle'., Ihor Radchenko, 2022/09/28
- Re: [PATCH 2-v1] New: auto display inline images under subtree when `org-cycle'., Christopher M. Miles, 2022/09/29
- Re: [PATCH 2-v1 (test v1)] New: auto display inline images under subtree when `org-cycle'., Christopher M. Miles, 2022/09/29
- Message not available
- Re: [PATCH 2-v1] New: auto display inline images under subtree when `org-cycle'., Ihor Radchenko, 2022/09/29
- Re: [PATCH 2-v2] New: auto display inline images under subtree when `org-cycle'., Christopher M. Miles, 2022/09/30
- Message not available
- Re: [PATCH 2-v2] New: auto display inline images under subtree when `org-cycle'., Ihor Radchenko, 2022/09/30
- Message not available
- [ISSUE] Re: [PATCH] New: auto display inline images under subtree when `org-cycle'., Christopher M. Miles, 2022/09/12