[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] org-refile.el: Fix test case
From: |
Maxim Nikulin |
Subject: |
Re: [PATCH 2/2] org-refile.el: Fix test case |
Date: |
Tue, 11 May 2021 18:45:34 +0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 09/05/2021 23:05, satotake wrote:
* lisp/org-refile.el (org-refile-get-targets): Check
`buffer-file-name' return value instead of `buffer-base-buffer'.
To pass the related tests, we need to check `buffer-file-name'.
Thank you for the patches. Maybe I have missed something, but it seems 2
patches are not logically independent, second one touches the same code
to fix regression in tests. If so, could you, please, squash both
patches into a single one (e.g. using git rebase --interactive)? I hope,
it will help to review the change and to avoid confusion with several
versions of second patch in 2 threads.
Code around has at least one more problem: questionable behavior in the
case of indirect buffers (e.g. C-x 4 c). Refile targets cache, when
enabled, is not reused for indirect buffer.
On 09/05/2021 21:47, satotake wrote:
I often use org-mode for note-taking and so on.
Sometimes, I would like to refile the headings in the scratch to other
org files while I am writing.
Have you tried org-capture? https://orgmode.org/manual/Capture.html
https://sachachua.com/blog/2015/02/learn-take-notes-efficiently-org-mode/#unnumbered-3
I think, existence of this feature is the reason why this bug was
remaining unnoticed.
- org-refile.el: Fix the case of emtpy buffer name, satotake, 2021/05/09
- [PATCH] org-refile.el: Fix the case of emtpy buffer name, satotake, 2021/05/09
- Re: org-refile.el: Fix the case of emtpy buffer name, satotake, 2021/05/09
- [PATCH 2/2] org-refile.el: Fix test case, satotake, 2021/05/09
- [PATCH 2/2] org-refile.el: Fix test case, satotake, 2021/05/09
- Re: [PATCH 2/2] org-refile.el: Fix test case,
Maxim Nikulin <=
- Re: org-refile.el: Fix test case (Squashed), satotake, 2021/05/13
- [PATCH] org-refile.el: Fix the case of emtpy buffer name, satotake, 2021/05/13
- Re: [PATCH] org-refile.el: Fix the case of emtpy buffer name, Maxim Nikulin, 2021/05/14
- Re: [PATCH] org-refile.el: Fix the case of emtpy buffer name, Bastien, 2021/05/15
- Re: [PATCH] org-refile.el: Fix the case of emtpy buffer name, satotake, 2021/05/15
- [PATCH] org-refile.el: Fix the case of *scratch* buffer, satotake, 2021/05/15