emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] org-src.el Do not ask to revert unmodified buffers


From: Kyle Meyer
Subject: Re: [PATCH] org-src.el Do not ask to revert unmodified buffers
Date: Sun, 21 Mar 2021 16:33:25 -0400

Thanks for the patch.

pillule writes:

> Hi, it is asked to the user if we want to revert changes when 
> re-entering in a org-source buffer.
> Even if the buffer have no modifications.

Hmm, that description seems to be focusing on the prompt's parenthetical
note.  When org-src-ask-before-returning-to-edit-buffer is non-nil and
there's an existing source buffer, the caller is asked whether to return
to it or regenerate/overwrite it.  The message warns that the second
option (i.e. answering "no, don't return to existing buffer") will
discard changes.

It looks like this patch assumes that, when the buffer is unmodified,
the answer to the above question necessarily becomes "yes, return to the
existing buffer", but it's not clear to me why that should be.  With an
unmodified buffer, I suppose there's less of a difference between the
two answers, but at least with the default org-src-window-setup value,
there's still a user-visible difference in terms of window organization.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]