emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Bug: org-link-descriptive and org-toggle-link-display [9.4 (9.4-44-g5272


From: Gustavo Barros
Subject: Bug: org-link-descriptive and org-toggle-link-display [9.4 (9.4-44-g5272d9-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201123/)]
Date: Tue, 24 Nov 2020 14:44:09 -0300
User-agent: mu4e 1.4.13; emacs 27.1

Hi All,

there is a scope mismatch in `org-toggle-link-display' between text (visibility) properties and the setting of `org-link-descriptive'. The text properties are set for the buffer with either `remove-from-invisibility-spec' or `add-to-invisibility-spec', but the value of `org-link-descriptive` is set globally with `(setq org-link-descriptive (not org-link-descriptive))'. It is not a big deal, but it does lead to a glitch in `org-toggle-link-display'.

It is easy to generate an ECM to trigger the glitch:

- Start `emacs -Q'
- Load the latest:
 #+begin_src emacs-lisp
 (add-to-list 'load-path "~/.emacs.d/elpa/org-plus-contrib-20201123")
 #+end_src

- Open two Org buffers "*Buffer 1*" with contents:
 #+begin_src org
 [[https://orgmode.org/][Org mode for Emacs]]
 #+end_src
- And "*Buffer 2*" with contents:
 #+begin_src org
 [[https://orgmode.org/worg/][Hello Worg, the Org-Mode Community!]]
 #+end_src
- It's probably easier to visualize if you have both windows in view in a split frame, but it should not change the result whatever you do. - The initial state, as per defaults, is that links are invisible in both buffers.

- Go to "*Buffer 1*" and `M-x org-toggle-link-display', and links are made visible in that buffer, but not in "*Buffer 2*".

- Now, go to "*Buffer 2*" and call `M-x org-toggle-link-display' there. It doesn't work. Call it again. Now it does.

What's happening is that, when we call `org-toggle-link-display' in "*Buffer 1*" we set `org-link-descriptive' to nil globally, so that when we move to "*Buffer 2*", Org thinks the links are visible, and when we call `org-toggle-link-display' then, Org will try to "re-hide" the links that are already invisible, with no apparent effect. But, in doing so, it also sets `org-link-descriptive' to t again, also globally. And so a second call will work.

I don't know if it's better to make `org-link-descriptive' buffer-local, or to simply use `setq-local' in `org-toggle-link-display'. Either way, it is a low hanging one.

Best regards,
Gustavo.




Emacs : GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0)
of 2020-08-11
Package: Org mode version 9.4 (9.4-44-g5272d9-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201123/)

current state:
==============
(setq
org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
org-link-shell-confirm-function 'yes-or-no-p
org-metadown-hook '(org-babel-pop-to-session-maybe)
org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
org-link-descriptive nil
org-mode-hook '(#[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-show-all append local] 5]
                 #[0 "\300\301\302\303\304$\207"
[add-hook change-major-mode-hook org-babel-show-result-all append local] 5] org-babel-result-hide-spec org-babel-hide-all-hashes org-eldoc-load)
org-archive-hook '(org-attach-archive-delete-maybe)
org-confirm-elisp-link-function 'yes-or-no-p
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-metaup-hook '(org-babel-load-in-session-maybe)
org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3 "\n\n(fn ENTRY)"]
org-babel-pre-tangle-hook '(save-buffer)
org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
org-agenda-loop-over-headlines-in-active-region nil
org-src-lang-modes '(("redis" . redis) ("php" . php) ("arduino" . arduino) ("C" . c) ("C++" . c++) ("asymptote" . asy) ("bash" . sh) ("beamer" . latex) ("calc" . fundamental) ("cpp" . c++) ("ditaa" . artist) ("dot" . fundamental) ("elisp" . emacs-lisp) ("ocaml" . tuareg) ("screen" . shell-script) ("shell" . sh) ("sqlite" . sql))
org-occur-hook '(org-first-headline-recenter)
org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines
                  org-optimize-window-after-visibility-change)
org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate)
org-export-before-parsing-hook '(org-attach-expand-links)
org-confirm-shell-link-function 'yes-or-no-p
org-link-parameters '(("attachment" :follow org-attach-follow :complete org-attach-complete-link) ("id" :follow org-id-open) ("eww" :follow org-eww-open :store org-eww-store-link) ("rmail" :follow org-rmail-open :store org-rmail-store-link) ("mhe" :follow org-mhe-open :store org-mhe-store-link) ("irc" :follow org-irc-visit :store org-irc-store-link :export org-irc-export) ("info" :follow org-info-open :export org-info-export :store org-info-store-link) ("gnus" :follow org-gnus-open :store org-gnus-store-link) ("docview" :follow org-docview-open :export org-docview-export :store
                        org-docview-store-link)
("bibtex" :follow org-bibtex-open :store org-bibtex-store-link) ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete org-bbdb-complete-link
                        :store org-bbdb-store-link)
("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs")
                       ("shell" :follow org-link--open-shell)
                       ("news" :follow
#[514 "\301\300\302Q\"\207" ["news" browse-url ":"] 6 "\n\n(fn URL ARG)"])
                       ("mailto" :follow
#[514 "\301\300\302Q\"\207" ["mailto" browse-url ":"] 6 "\n\n(fn URL ARG)"])
                       ("https" :follow
#[514 "\301\300\302Q\"\207" ["https" browse-url ":"] 6 "\n\n(fn URL ARG)"])
                       ("http" :follow
#[514 "\301\300\302Q\"\207" ["http" browse-url ":"] 6 "\n\n(fn URL ARG)"])
                       ("ftp" :follow
#[514 "\301\300\302Q\"\207" ["ftp" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("help" :follow org-link--open-help) ("file" :complete org-link-complete-file) ("elisp" :follow org-link--open-elisp) ("doi" :follow org-link--open-doi))
org-link-elisp-confirm-function 'yes-or-no-p
)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]