|Subject:||Re: [PATCH] improve ol-man.el with occur searching|
|Date:||Mon, 31 Aug 2020 18:34:27 +0800|
Thanks for reviewing my code and points. :)Fixed in this attached patch.[stardiviner] <Hack this world!> GPG key ID: 47C32433
IRC(freeenode): stardiviner Twitter: @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/On Sun, Aug 16, 2020 at 5:54 PM Nicolas Goaziou <firstname.lastname@example.org> wrote:Hello,
"email@example.com" <firstname.lastname@example.org> writes:
> With this patch, ol-man.el link type can be a link like this:
> [[man:grep::--extended-regexp][grep --extended-regexp]]
> Occur will auto search "--extended-regexp" string in man page buffer.
> +PATH should be a topic that can be thrown at the man command.
> +If PATH contains extra ::STRING which will use `occur' to search
> +matched strings in man buffer."
> + (string-match "\\(.*?\\)\\(?:::\\(.*\\)\\)?$" path)
> + (let* ((command (match-string 1 path))
> + (search (match-string 2 path)))
> + (funcall org-man-command command)
> + (with-current-buffer (concat "*Man " command "*")
This should only be called if search is non-empty.
> + (occur search))))
Why occur? Org uses `search-forward' for [[foo.org::text]] text links,
and uses `occur' with [[foo.org::/text/]] links.
Wouldn't it be more idiomatic to use a regular text search here?
|[Prev in Thread]||Current Thread||[Next in Thread]|