[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new feature for consideration: other-tab for org-agenda-window-setup

From: Kyle Meyer
Subject: Re: new feature for consideration: other-tab for org-agenda-window-setup
Date: Fri, 28 Aug 2020 00:27:29 -0400

Eric S Fraga writes:

> Dear all,
> Please see attached for a new version of my changes for adding
> 'other-tab as an option for org-agenda-window-setup.
> I think I've addressed all your comments, Kyle, but any more are
> welcome.  It would be good if somebody who is using an older version of
> Emacs, i.e. pre 27.1, could test the error handling: set
> org-agenda-window-setup to 'other-tab and see if it fails properly.  I
> only have v28.x on my systems!
> On v28.x, it seems to be working fine.

Thanks for the updated patch.  I've tested it on 26.3 as well as the
Emacs master branch.

> @@ -3769,6 +3776,10 @@ FILTER-ALIST is an alist of filters we need to apply 
> when
>        (org-switch-to-buffer-other-window abuf))
>       ((eq org-agenda-window-setup 'other-frame)
>        (switch-to-buffer-other-frame abuf))
> +     ((eq org-agenda-window-setup 'other-tab)
> +      (if (fboundp 'switch-to-buffer-other-tab)
> +       (switch-to-buffer-other-tab abuf)
> +     (user-error "Your version of Emacs does not have tab bar support.")))

Sorry, I've got another consistency/style nit-pick for you: the
convention is to omit the trailing period from error messages.  (No need
to resend for that.  I'll plan to adjust when applying.)

I'll let this sit for another day to see if other comments come in.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]