[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Update org-clock-out-time when resolving clocks

From: Kyle Meyer
Subject: Re: [PATCH] Update org-clock-out-time when resolving clocks
Date: Mon, 17 Aug 2020 00:13:34 -0400

Benson Chu writes:

> I noticed this while using `org-resolve-clocks' when
> `org-clock-continuously' was set to true.
> Let's say I clock into "Task 1" at 12:00, and then at 12:30, I start
> working on "Task 2". Then, at 12:45, I notice that I forgot to clock out
> of "Task 1". No worries, org-mode has `org-resolve-clocks'! So, I invoke
> `org-resolve-clocks', keep 30 minutes, and then clock into "Task
> 2". However, when I clock in, the clock start time is 12:45, violating
> the promise that `org-clock-continuously' makes.
> This patch updates the variable `org-clock-out-time' when `org-clock-out'
> gets passed an `at-time', which fixes the issue I run into.

Thanks for the patch.  It looks correct to me.

> The patch is attached. Is there anything else I need to do?

The only thing I noticed missing is a TINYCHANGE cookie...

> Subject: [PATCH] org-clock.el: Update org-clock-out-time from
>  org-resolve-clocks
> * lisp/org-clock.el (org-clock-out): If `at-time' was passed, set
> org-clock-out-time to that value. Otherwise, set it to now.

... here.  I've added it when applying (bd97851c4).

Thanks again.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]