Re: commit "328c9a1af * bad org.el: Enhance menus" caused error

[stardiviner]

Bastien <address@hidden> writes:

> Hi,
>
> stardiviner <address@hidden> writes:
>
>> BTW, the function ~org-insert-dblock-bindings~ is from package
>> =orgtbl-aggregate=.
>
> I don't know this function and this package.
>
> Can you share the minimal Emacs config with which you reproduce
> the problem?

Start =emacs -q=, and load Org from source code.

Then load package =orgtbl-aggregate=.

#+begin_src emacs-lisp
(use-package orgtbl-aggregate
  :ensure t
  :commands (org-insert-dblock org-insert-dblock:aggregate)
  :config
  ;; add `orgtbl-aggregate' dynamic blocks into list.
  (org-dynamic-block-define "columnview" 'org-insert-dblock:columnview)
  (org-dynamic-block-define "aggregate" 'org-insert-dblock:aggregate)
  (org-dynamic-block-define "invoice" 'org-insert-dblock:invoice)
  (org-dynamic-block-define "join" 'org-insert-dblock:join)
  (org-dynamic-block-define "org-gantt" 'org-insert-dblock:org-gantt)
  (org-dynamic-block-define "propview" 'org-insert-dblock:propview)
  (org-dynamic-block-define "transpose" 'org-insert-dblock:transpose))
#+end_src

Actually, it is because this package contains following code cause this problem:

#+begin_src emacs-lisp
;;;###autoload
(defun org-insert-dblock-bindings ()
  (org-defkey org-mode-map "\C-c\C-xi" 'org-insert-dblock)
  (easy-menu-add-item
   org-org-menu '()
   ["Insert Dynamic Block" org-insert-dblock t] "Agenda Command..."))

;;;###autoload
(if (functionp 'org-defkey)
    (org-insert-dblock-bindings) ;; org-mode already loaded
  (setq org-load-hook            ;; org-mode will be loaded later
        (cons 'org-insert-dblock-bindings
              (if (boundp 'org-load-hook)
                  org-load-hook))))
#+end_src

Maybe because I just use =use-package= autoload for =orgtbl-aggregate= instead 
of
fully required? I tested that now by removing ~:commands~ part so that 
use-package
will not load delayed. Still has this error.

-- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3