[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] org-icalendar: Change dates to today in VEVENT export
From: |
Nicolas Goaziou |
Subject: |
Re: [O] org-icalendar: Change dates to today in VEVENT export |
Date: |
Thu, 05 Sep 2019 18:52:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
Michaël Cadilhac <address@hidden> writes:
> Hopefully I didn't miss anything—I've been running the patched version for
> weeks now, so it should be stable in any case. Patch 0003 above should
> still be OK.
Thank you.
> +(defcustom org-icalendar-summary-uses-tags nil
> + "Whether tags should be added to the title to create the summary.
> +
> +If a SUMMARY is provided in the entry, this is irrelevant.
> +If non-nil, it can be set to `local-tags' or `all-tags' indicating which tags
> +are used to make up the summary: only tags defined in the current line or all
> +tags including inherited ones, respectively."
> + :group 'org-export-icalendar
> + :type '(choice
> + (const :tag "Use the tags defined in current line" local-tags)
> + (const :tag "Use all tags, including inherited ones" all-tags)
> + (const :tag "Do not use tags in summary" nil)))
There are missing keywords (:package-version, :safe).
> +(defun org-icalendar-today-timestamp ()
> + "Return a TIMESTAMP object for today, at 00:00."
> + (let ((dt (decode-time)))
> + (list 'timestamp
> + (nconc (list :year-start (nth 5 dt)
> + :year-end (nth 5 dt)
> + :month-start (nth 4 dt)
> + :month-end (nth 4 dt)
> + :day-start (nth 3 dt)
> + :day-end (nth 3 dt))))))
This function already exists: `org-timestamp-from-time'. Could you use
that instead?
Othewise, LGTM.
Regards,
--
Nicolas Goaziou
- Re: [O] org-icalendar: Change dates to today in VEVENT export,
Nicolas Goaziou <=