[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Add feature to org-drill to auto pronounce word

From: Nicolas Goaziou
Subject: Re: [O] [PATCH] Add feature to org-drill to auto pronounce word
Date: Sat, 26 Jan 2019 12:40:01 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)


stardiviner <address@hidden> writes:

> A gentle ping..

I'm not sure "org-drill.el" is still actively maintained. I'm Cc'ing
Paul Sexton. In the long run, I think this package could be packaged
through ELPA instead.

>> * etc/ORG-NEWS: mentioned this new feature.

Changes to "contrib/" directory are usually not mentioned in this file.

>> +(defun org-drill-pronounce-word ()
>> +  "Pronounce word after querying."
>> +  (if org-drill-auto-pronounce
>> +      (shell-command-to-string
>> +       (format "%s %s %s &"
>> +           org-drill-pronounce-command org-drill-pronounce-command-args

What are `org-drill-pronounce-command' and
`org-drill-pronounce-command-args'? I don't see them defined anywhere.

Also, please prefer `when' to one-armed `if'.

>> +           (shell-quote-argument
>> +            (substring-no-properties
>> +             (org-get-heading 'no-tags 'no-todo 'no-priority 
>> 'no-comment)))))))
>> +
>> +(add-hook 'org-drill-entry-after-hook #'org-drill-pronounce-word)

Could it be more integrated? Using hook is usually for users. If you can
modify the code, you probably can do better.


Nicolas Goaziou

reply via email to

[Prev in Thread] Current Thread [Next in Thread]