[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [patch] get modification-time from vc
From: |
Rasmus |
Subject: |
Re: [O] [patch] get modification-time from vc |
Date: |
Wed, 18 May 2016 21:45:25 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
Hi,
Thanks for the comments!
Nicolas Goaziou <address@hidden> writes:
> Why enforcing "vc" and not any non-nil/non-empty second argument instead ?
No point, really.
>> Is cl-lib OK now?!
>
> cl-lib is OK in master. Minimal requirement for master is Emacs 24.3.
Cool.
>> + (when (cl-some 'identity time)
>> + (setq date (apply #'encode-time time))))))))
>
> Why #'encode-time and not #'identity ?
To test if you review the all the way to the end! Or...
> In any case, this looks good. Please push when you're happy with the
> result.
Pushed.
Rasmus
--
And when I’m finished thinking, I have to die a lot