[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] org-player and switch to lexical binding in org.el
From: |
Michael Brand |
Subject: |
Re: [O] org-player and switch to lexical binding in org.el |
Date: |
Sun, 17 Jan 2016 22:02:42 +0100 |
Hi Paul
It seems that this is beyond of my knowledge and I would like to ask
you as the author of org-player for help.
On Sun, Jan 17, 2016 at 9:40 PM, Nicolas Goaziou <address@hidden> wrote:
> Hello,
>
> Michael Brand <address@hidden> writes:
>
>> release_8.3.3-426-g1f49e9f introduces a regression. The link
>>
>> [[file:/dir/audio.mp3::0:12:34]]
>>
>> results in
>>
>> Debugger entered--Lisp error: (void-variable search)
>> (org-player-play-file file search)
>> [...]
>> org-open-file("/dir/audio.mp3" nil nil "0:12:34")
>> [...]
>
> `search' never was advertised as a dynamically scoped variable in
> `org-file-apps' docstring, so "org-player" is just playing with fire
> here.
>
> I don't like the current solution either (eval with a LEXICAL argument).
>
> I think it would be better to use un function with two arguments (file
> and link-string instead). This is not backward compatible, but the
> change is trivial: sexp -> (lambda (file link) sexp).
>
> In the current case, you need to use match string:
>
> (add-to-list 'org-file-apps
> (cons (concat org-player-file-extensions-regexp
> "::\\([0-9]+:[0-9]+\\(:[0-9]+\\)?\\)")
> (lambda (file link)
> (org-player-play-file file (match-string 1 link)))))
>
> WDYT?
>
>
> Regards,
>
> --
> Nicolas Goaziou
Michael