[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[O] [PATCH] org-protocol: Allow key=val&key2=value2-style URLs
From: |
Sacha Chua |
Subject: |
[O] [PATCH] org-protocol: Allow key=val&key2=value2-style URLs |
Date: |
Fri, 04 Dec 2015 17:55:29 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
Aaron Ecay <address@hidden> writes:
Hello, Aaron, Rasmus, all!
> better solution IMO would be to make org-protocol links valid urls in
> another way, using the query string format:
> org-protocol://store-link?url=[...]&title=[...]
Aaron: Great point! I've changed my code to support this style of
org-protocol link, and I think the tests I've added to
test-org-protocol.el double-check that old links are still supported.
I've added an extra argument to the functions defined in
org-protocol-protocol-alist and org-protocol-protocol-alist-default, but
I have a condition-case around the funcall so that old functions should
continue to work. I've updated the documentation to encourage new-style
links. What do you think of this patch? I've changed the subject to
reflect the new focus.
Rasmus: that means fiddling with ports is no longer needed, yay. I've
also added the test dependency and lexical binding cookie to
test-org-protocol, as you suggested. Since the missing-test-dependency
signal means that the test isn't run as part of make test, is there
anything I should do to get it to be included in automated tests, or is
it fine leaving it as is?
Sacha
0001-org-protocol-Allow-key-val-key2-val2-style-URLs.patch
Description: Text Data
- [O] [PATCH] org-protocol: Allow optional port specification, Sacha Chua, 2015/12/02
- Re: [O] [PATCH] org-protocol: Allow optional port specification, Rasmus, 2015/12/02
- Re: [O] [PATCH] org-protocol: Allow optional port specification, Aaron Ecay, 2015/12/03
- [O] [PATCH] org-protocol: Allow key=val&key2=value2-style URLs,
Sacha Chua <=
- Re: [O] [PATCH] org-protocol: Allow key=val&key2=value2-style URLs, Aaron Ecay, 2015/12/05
- Re: [O] [PATCH] org-protocol: Allow key=val&key2=value2-style URLs, Sacha Chua, 2015/12/07
- Re: [O] [PATCH] org-protocol: Allow key=val&key2=value2-style URLs, Sacha Chua, 2015/12/07
- Re: [O] [PATCH] org-protocol: Allow key=val&key2=value2-style URLs, Sacha Chua, 2015/12/18
- Re: [O] [PATCH] org-protocol: Allow key=val&key2=value2-style URLs, Nicolas Goaziou, 2015/12/20
- Re: [O] [PATCH] org-protocol: Allow key=val&key2=value2-style URLs, Sacha Chua, 2015/12/21
- Re: [O] [PATCH] org-protocol: Allow key=val&key2=value2-style URLs, Nicolas Goaziou, 2015/12/22