[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] C-u C-u C-c ! inserts an active timestamp.

From: Sebastien Vauban
Subject: Re: [O] C-u C-u C-c ! inserts an active timestamp.
Date: Mon, 23 Sep 2013 11:16:25 +0200
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (windows-nt)

Hello Suvayu,

Suvayu Ali wrote:
> On Mon, Sep 23, 2013 at 10:51:33AM +0200, Nicolas Richard wrote:
>> Carsten Dominik <address@hidden> writes:
>> > Applied
>> I noticed that the whole mail went into the commit msg (commit
>> 12de6223dcd736c0958eca874def052b407ff5d1) ; did I send the patch
>> incorrectly ?
>> I used git format-patch then inserted the result at the end of the email
>> I wrote. The page http://orgmode.org/worg/org-contribute.html#sec-4 is
>> not very explicit about how to send the result of `git format-patch',
>> but I seem to remember it was ok to just yank the content at the end of
>> a mail. Is that a wrong assumption ?
> Simply attaching the patch as a text attachment should do fine I think.

Though, many guidelines tell:

  Do not attach your patch, but submit it "inline" in the mail body,
  /unless you cannot teach your mailer to leave the formatting
  of the patch alone/.

That allows for easy reviews... and easy comments (after every chunk of code).

Best regards,

Sebastien Vauban

reply via email to

[Prev in Thread] Current Thread [Next in Thread]