[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] Jumping from source block to Org block ...

From: Eric Schulte
Subject: Re: [O] Jumping from source block to Org block ...
Date: Sun, 15 Sep 2013 05:52:35 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

aditya siram <address@hidden> writes:

> Thanks for your feedback and your work on org-babel!

I'm happy you're finding it useful.

> Oops, the maintain-point was a hold-over and isn't actually used in the
> code. I'll remove it.
> I will incorporate your suggestions.
> However, regarding the cascading if statements, how would I use `cond` when
> the predicates are `and`ed and when I need different behavior in the else
> cases?

Maybe cascading if statements are the best thing here.  Perhaps changing
the order of the then/else branches could ensure the conditionals are
still visible from the branches, but this is an exceedingly minor point.

I guess any use of cond could easily get overly verbose.  Please
disregard this suggestion.


> On Sat, Sep 14, 2013 at 10:44 AM, Eric Schulte <address@hidden>wrote:
>> aditya siram <address@hidden> writes:
>> > Attached is a patch that fixes a bug with jumping from source block back
>> to
>> > the Org file. The problem is that the current detangling behavior does
>> not
>> > take the :padlline flag into account. This stopped.
>> >
>> > Hopefully this is helpful to others ...
>> > -deech
>> >
>> Hi deech,
>> Please see the Org-mode contribution instructions at [1].  A patch of
>> this length would require that you fill out the FSF copyright assignment
>> paperwork before the patch could be applied.
>> As for the content of the patch, my only question is why do you add an
>> optional maintain-point argument to `org-babel-tangle-jump-to-org'?  Is
>> there ever a case when you would not want to maintain the point?
>> Of much less importance I have a couple of stylistic notes about the
>> code which are largely unrelated to its functionality and are included
>> to make future changes easier to read and because I'm a cranky old lisp
>> programmer.
>> - you should indent the code s.t. no lines are longer than 79 characters
>> - comments which float after code (e.g., ";; end of first delimiter")
>>   should only use 1 ; character
>> - the series of if statements (if should-be-padded... if
>>   possibly-padded... if actually-padded...) would be more legible if
>>   written as a single `cond' form.
>> Thanks for this change.  It appears to pass all tests, so after the
>> above have been addressed I'd be very happy to apply it.
>> Thanks for contributing, this is much appreciated!
>> If you have the time and inclination to include a test which fails
>> without this patch applied that would be icing on the cake.
>> Best,
>> Footnotes:
>> [1]  http://orgmode.org/worg/org-contribute.html
>> --
>> Eric Schulte
>> https://cs.unm.edu/~eschulte
>> PGP: 0x614CA05D

Eric Schulte
PGP: 0x614CA05D

reply via email to

[Prev in Thread] Current Thread [Next in Thread]