emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] ox-html: Restore wrongly omitted table attributes under


From: Kodi Arfer
Subject: Re: [O] [PATCH] ox-html: Restore wrongly omitted table attributes under HTML5.
Date: Sat, 29 Jun 2013 19:30:42 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6

On 2013 Jun 29 Sat 6:37:33 PM -0400, Nicolas Goaziou <address@hidden> wrote:
Kodi Arfer <address@hidden> writes:

 From edd97671641e28c3e240efe6ea8fa8d77b4b7eae Mon Sep 17 00:00:00 2001
From: Kodi Arfer <address@hidden>
Date: Sat, 29 Jun 2013 10:43:07 -0400
Subject: [PATCH] ox-html: Restore wrongly omitted table attributes under
  HTML5.

* lisp/ox-html.el (org-html-table): For HTML5,
   omit :html-table-attributes but not :id or :attr_html.

Thank you for your patch. Could you rebase it against "maint"? I cannot
apply it at the moment.

I don't think I can. I'm not clear about the relationship between maint and master in general, but it looks like maint doesn't have the bug my patch is supposed to fix, because it doesn't treat an HTML5 doctype specially at all.

+              (unless (org-html-html5-p info)
+                (plist-get info :html-table-attributes))

One nitpick. It is more explicit to use:

   (and (not (org-html-html5-p info))
        (plist-get info :html-table-attributes))

since you are using the returned value.

Sure, I can change that. Should I base the patch off master again?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]