emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] scratch/logview 7bcfd6b103 3/5: (logview--do-append-log-file-ta


From: Stefan Monnier
Subject: [nongnu] scratch/logview 7bcfd6b103 3/5: (logview--do-append-log-file-tail): Use `bufferpos-to-filepos`
Date: Thu, 27 Mar 2025 17:43:56 -0400 (EDT)

branch: scratch/logview
commit 7bcfd6b1033b20fcb279473782268e84660b0ccb
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    (logview--do-append-log-file-tail): Use `bufferpos-to-filepos`
---
 logview.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/logview.el b/logview.el
index 3f9f62f5bd..4ebb1a4310 100644
--- a/logview.el
+++ b/logview.el
@@ -2955,9 +2955,7 @@ returns non-nil."
          (size               (1+ (buffer-size)))
          (reassurance-chars  (min (max logview-reassurance-chars 0) (1- size)))
          (compare-from       (- size reassurance-chars))
-         ;; 'position-bytes' appears to count from 1, yet we need
-         ;; zero-based offset.
-         (compare-from-bytes (1- (position-bytes compare-from))))
+         (compare-from-bytes (bufferpos-to-filepos compare-from)))
     (with-temp-buffer
       ;; As of Emacs 30 this fails when trying to read past the end of the 
file (in earlier Emacs versions it
       ;; works, but doesn't insert anything).  Don't care to report anything 
to Emacs-devel (maybe it's even



reply via email to

[Prev in Thread] Current Thread [Next in Thread]