[nongnu] elpa/helm 138afd24ae 2/4: Fix initial setting of helm-split-window-state (#2635)

[ELPA Syncer]

branch: elpa/helm
commit 138afd24aea65344779be2b038645b30cd50c190
Author: Thierry Volpiatto <thievol@posteo.net>
Commit: Thierry Volpiatto <thievol@posteo.net>

    Fix initial setting of helm-split-window-state (#2635)
    
    We were previously checking split-witdth-threshold which is now let-bounded 
to
    helm-split-width-threshold (was not existing at the time), check
    instead helm-split-width-threshold.
    In addition a check of helm-split-window-default-side is done which
    IMO make sense as well.
---
 helm-core.el | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/helm-core.el b/helm-core.el
index 2349111f13..f97ddb31d3 100644
--- a/helm-core.el
+++ b/helm-core.el
@@ -3716,10 +3716,14 @@ Argument SAVE-OR-RESTORE is either save or restore."
   (unless (and (or helm-split-window-state
                    helm--window-side-state)
                helm-reuse-last-window-split-state)
+    ;; `helm-split-window-state' should be the contrary of what we currently
+    ;; have to allow toggling windows with C-t.
     (setq helm-split-window-state
-          (if (or (null split-width-threshold)
-                  (and (integerp split-width-threshold)
-                       (>= split-width-threshold (+ (frame-width) 4))))
+          (if (or (null helm-split-window-default-side) ; same as below.
+                  (memq helm-split-window-default-side '(below above))
+                  (null helm-split-width-threshold)
+                  (and (integerp helm-split-width-threshold)
+                       (>= helm-split-width-threshold (+ (frame-width) 4))))
               'vertical 'horizontal))
     (setq helm--window-side-state
           (or helm-split-window-default-side 'below)))