emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/mastodon 6d80f5b2d2 12/52: minor-view fixme


From: ELPA Syncer
Subject: [nongnu] elpa/mastodon 6d80f5b2d2 12/52: minor-view fixme
Date: Mon, 30 Oct 2023 16:01:24 -0400 (EDT)

branch: elpa/mastodon
commit 6d80f5b2d2dd71a0e28a7bcb700e8fb1757ac8d6
Author: marty hiatt <martianhiatus [a t] riseup [d o t] net>
Commit: marty hiatt <martianhiatus [a t] riseup [d o t] net>

    minor-view fixme
---
 lisp/mastodon-views.el | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/lisp/mastodon-views.el b/lisp/mastodon-views.el
index 20734ae413..d7fedb6a8e 100644
--- a/lisp/mastodon-views.el
+++ b/lisp/mastodon-views.el
@@ -164,9 +164,12 @@ request.
 This function is used as the update-function to
 `mastodon-tl--init-sync', which initializes a buffer for us and
 provides the JSON data."
-  ;; FIXME: this breaks pagination, duh!
-  (erase-buffer)
-  (mastodon-search--insert-heading view-name) ; this cd go in init-sync
+  ;; FIXME: this is not an update function as it inserts a heading and
+  ;; possible bindings string
+  ;; either it should go in init-sync, or possibly in each view function
+  ;; but either way, this function does almost nothing for us.
+  ;; could we call init-sync in here pehaps?
+  (mastodon-search--insert-heading view-name)
   (when bindings-string
     (insert (mastodon-tl--set-face (concat "[" bindings-string "]\n\n")
                                    'font-lock-comment-face)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]