emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/transient 7c08beb8d2: Revert "transient-{set, save, re


From: Jonas Bernoulli
Subject: [elpa] externals/transient 7c08beb8d2: Revert "transient-{set, save, reset}: Stay transient"
Date: Tue, 19 Sep 2023 09:03:15 -0400 (EDT)

branch: externals/transient
commit 7c08beb8d2c8a071c9e947617dbee369f17add84
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    Revert "transient-{set,save,reset}: Stay transient"
    
    This reverts commit 361d8ac61bf75e027173f84a1013d87364a4ec3e.
    
    The goal of that commit was to ensure that the transient stays
    active when invoking one of these commands.
    
    However both of these pre-commands are supposed to do that, so while
    moving from one to the other, did seem to address that issue,
    something else must be going on, which will have to be investigated
    (including why `transient--do-call' only misbehaves for these suffix
    commands in combination of certain prefix commands).
    
    More importantly though, this commit has to be reverted because it
    introduced a regression, which is worse than the minor defect it fixed.
    These commands depend on variables being exported.  The only intended
    difference between the two pre-commands is that `transient--do-call'
    exports variables, so switching to `transient--do-stay' made no sense.
    
    Closes #257.
---
 lisp/transient.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/transient.el b/lisp/transient.el
index 5a956df135..2618357613 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -1625,9 +1625,9 @@ of the corresponding object."
   "<transient-show>"              #'transient--do-stay
   "<transient-update>"            #'transient--do-stay
   "<transient-toggle-common>"     #'transient--do-stay
-  "<transient-set>"               #'transient--do-stay
-  "<transient-save>"              #'transient--do-stay
-  "<transient-reset>"             #'transient--do-stay
+  "<transient-set>"               #'transient--do-call
+  "<transient-save>"              #'transient--do-call
+  "<transient-reset>"             #'transient--do-call
   "<describe-key-briefly>"        #'transient--do-stay
   "<describe-key>"                #'transient--do-stay
   "<transient-scroll-up>"         #'transient--do-stay



reply via email to

[Prev in Thread] Current Thread [Next in Thread]