emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/git-commit eb66aed3b4 2/2: Remove useless magit-branch-des


From: ELPA Syncer
Subject: [nongnu] elpa/git-commit eb66aed3b4 2/2: Remove useless magit-branch-description-check-buffers
Date: Fri, 17 Mar 2023 14:00:19 -0400 (EDT)

branch: elpa/git-commit
commit eb66aed3b4a4cfb3380897157f4443404d1b1f9b
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    Remove useless magit-branch-description-check-buffers
    
    The value of functions on `find-file-hook' has no relevance and
    this function has no side-effects.  It should have been removed
    in [1: c07b475051], instead of merely being renamed and losing
    the side-effect it used to have.  It used to refresh the popup
    buffer, which became irrelevant when we switched to `transient'
    in that commit.
    
    1: 2019-02-14 c07b47505115564d8c79b988fe204844d8da3b3f
       Define magit-branch-configure as a transient command
---
 lisp/magit-branch.el | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/lisp/magit-branch.el b/lisp/magit-branch.el
index 527c2164ca..3e80201e2b 100644
--- a/lisp/magit-branch.el
+++ b/lisp/magit-branch.el
@@ -846,12 +846,6 @@ and also rename the respective reflog file."
   (interactive (list (oref transient-current-prefix scope)))
   (magit-run-git-with-editor "branch" "--edit-description" branch))
 
-(add-hook 'find-file-hook #'magit-branch-description-check-buffers)
-
-(defun magit-branch-description-check-buffers ()
-  (and buffer-file-name
-       (string-match-p "/\\(BRANCH\\|EDIT\\)_DESCRIPTION\\'" 
buffer-file-name)))
-
 (defclass magit--git-branch:upstream (magit--git-variable)
   ((format :initform " %k %m %M\n   %r %R")))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]