[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/websocket 01c8d98f69 011/114: * websocket.el: Remove us
From: |
ELPA Syncer |
Subject: |
[elpa] externals/websocket 01c8d98f69 011/114: * websocket.el: Remove use of buffers in connections. This simplifies |
Date: |
Wed, 15 Feb 2023 20:58:55 -0500 (EST) |
branch: externals/websocket
commit 01c8d98f697168ae24d0a5f9d76787aa713f2967
Author: Andrew Hyatt <ahyatt@gmail.com>
Commit: Andrew Hyatt <ahyatt@gmail.com>
* websocket.el: Remove use of buffers in connections. This simplifies
the code somewhat, and we avoid any possible buffer leaks.
---
websocket.el | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/websocket.el b/websocket.el
index d07d870d7a..2e8400ad05 100644
--- a/websocket.el
+++ b/websocket.el
@@ -556,9 +556,7 @@ connecting or open."
(make-websocket-frame :opcode 'close
:completep t))
(setf (websocket-ready-state websocket) 'closed))
- (let ((buf (process-buffer (websocket-conn websocket))))
- (delete-process (websocket-conn websocket))
- (kill-buffer buf)))
+ (delete-process (websocket-conn websocket)))
(defun websocket-ensure-connected (websocket)
"If the WEBSOCKET connection is closed, open it."
@@ -650,7 +648,6 @@ describing the problem with the frame.
(let* ((name (format "websocket to %s" url))
(url-struct (url-generic-parse-url url))
(key (websocket-genkey))
- (buf-name (format " *%s*" name))
(coding-system-for-read 'binary)
(coding-system-for-write 'binary)
(conn (if (member (url-type url-struct) '("ws" "wss"))
@@ -659,13 +656,12 @@ describing the problem with the frame.
(port (if (= 0 (url-port url-struct))
(if (eq type 'tls) 443 80)
(url-port url-struct)))
- (host (url-host url-struct))
- (buf (get-buffer-create buf-name)))
+ (host (url-host url-struct)))
(if (eq type 'plain)
- (make-network-process :name name :buffer buf :host
host
+ (make-network-process :name name :buffer nil :host
host
:service port :nowait nil)
(condition-case-unless-debug nil
- (open-network-stream name buf host port :type
type :nowait nil)
+ (open-network-stream name nil host port :type
type :nowait nil)
(wrong-number-of-arguments
(signal 'websocket-wss-needs-emacs-24 "wss")))))
(signal 'websocket-unsupported-protocol (url-type
url-struct))))
@@ -800,6 +796,7 @@ connection, which should be kept in order to pass to
:name (format "websocket server on port %d" port)
:server t
:family 'ipv4
+ :filter 'websocket-server-filter
:log 'websocket-server-accept
:filter-multibyte nil
:plist plist
@@ -841,7 +838,6 @@ connection, which should be kept in order to pass to
(unless (member ws websocket-server-websockets)
(push ws websocket-server-websockets))
(process-put client :websocket ws)
- (set-process-filter client 'websocket-server-filter)
(set-process-coding-system client 'binary 'binary)
(set-process-sentinel client
(lambda (process change)
- [elpa] externals/websocket 5f7decd210 006/114: Fix for on-close in websocket test, (continued)
- [elpa] externals/websocket 5f7decd210 006/114: Fix for on-close in websocket test, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 4ca9d4d32a 009/114: Set the version to 1.2, after the last set of server changes., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket f902bc04db 010/114: * websocket.el: Fix process-coding-system for client connections., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 6da0627a10 002/114: Correctly set websocket-server-p, and don't mask server communication., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket ee7797234b 012/114: * websocket.el: Throw clear error when connection cannot be made., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket ef975a91f1 008/114: Restore a bit of testing I accidentally deleted., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 8d0ca79cd3 036/114: Have functional test use :host 'local, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 97b7418dae 013/114: Permit non-numeric port number in websocket-server, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 28e55d5654 015/114: Fix misuse of same-origin policy, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket b9ae25843a 016/114: Fix breaking test., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 01c8d98f69 011/114: * websocket.el: Remove use of buffers in connections. This simplifies,
ELPA Syncer <=
- [elpa] externals/websocket 111febe203 020/114: Fix `websocket-version': update to 1.3, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 9aad2f754f 022/114: Add supports for <32 bit emacs., ELPA Syncer, 2023/02/15
- [elpa] externals/websocket dba6893ec5 023/114: Bump version to 1.4, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 965fac0fe5 027/114: add markdown preview mode, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 49a93b2218 028/114: Merge pull request #39 from ancane/master, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 90b9f03da0 029/114: Correctly parse fragmented HTTP header, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 8299e57a4c 033/114: Function test improvements for Windows: SIGSTP, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 4f8ddb64bc 034/114: Merge pull request #43 from chwarr/func-test-windows-sigstp, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 7422064ea6 035/114: Add a way to specify websocket-server listen host, ELPA Syncer, 2023/02/15
- [elpa] externals/websocket 923e74d686 038/114: Merge pull request #40 from ilysym/fragmented-header, ELPA Syncer, 2023/02/15