emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/git-commit ea5d557f4c 1/3: magit-section-maybe-update-visi


From: ELPA Syncer
Subject: [nongnu] elpa/git-commit ea5d557f4c 1/3: magit-section-maybe-update-visibility-indicator: Remove old kludge
Date: Tue, 29 Mar 2022 08:58:13 -0400 (EDT)

branch: elpa/git-commit
commit ea5d557f4c61e07f2174d8a4b0eb5c8c255b9aa9
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    magit-section-maybe-update-visibility-indicator: Remove old kludge
    
    This doesn't appear to be necessary anymore and I have my doubts
    that it ever was.  Tested with Emacs 25.1 and 29.0.50.
    
    Closes #4632.
---
 lisp/magit-section.el | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/lisp/magit-section.el b/lisp/magit-section.el
index 02cc0dc701..47d36cbc9d 100644
--- a/lisp/magit-section.el
+++ b/lisp/magit-section.el
@@ -1777,14 +1777,9 @@ invisible."
                   (line-end-position))))
       (cond
        ((symbolp (car-safe magit-section-visibility-indicator))
-        ;; It would make more sense to put the overlay only on the
-        ;; location we actually don't put it on, but then inserting
-        ;; before that location (while taking care not to mess with
-        ;; the overlay) would cause the fringe bitmap to disappear
-        ;; (but not other effects of the overlay).
-        (let ((ov (magit--overlay-at (1+ beg) 'magit-vis-indicator 'fringe)))
+        (let ((ov (magit--overlay-at beg 'magit-vis-indicator 'fringe)))
           (unless ov
-            (setq ov (make-overlay (1+ beg) eoh))
+            (setq ov (make-overlay beg eoh nil t))
             (overlay-put ov 'evaporate t)
             (overlay-put ov 'magit-vis-indicator 'fringe))
           (overlay-put



reply via email to

[Prev in Thread] Current Thread [Next in Thread]