[elpa] externals/pulsar 486645f81b 16/28: Always ':extend t' the generic pulse face

[ELPA Syncer]

branch: externals/pulsar
commit 486645f81bcafdb3a2e0acc4975b359b7ba8780f
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Always ':extend t' the generic pulse face
    
    This is to ensure that the highlight extends to the edge of the window
    as some themes do not necessarily have that set up.
    
    Thanks to Petter Storvik for reporting the problem in the discussion
    around issue 1: <https://gitlab.com/protesilaos/pulsar/-/issues/1>.
---
 pulsar.el | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/pulsar.el b/pulsar.el
index d84a2ff2c8..94ccbd7643 100644
--- a/pulsar.el
+++ b/pulsar.el
@@ -101,13 +101,14 @@ such as `customize-set-variable' do that automatically."
            (pulsar-setup)))
   :group 'pulsar)
 
-(defcustom pulsar-face 'pulse-highlight-start-face
+(defcustom pulsar-face 'pulsar-generic
   "Face to use for the pulse line.
-The default is `pulse-highlight-start-face', though users can
-select one among `pulsar-red', `pulsar-green', `pulsar-yellow',
-`pulsar-blue', `pulsar-magenta', `pulsar-cyan', or any other face
-that has a background attribute."
-  :type '(radio (face :tag "Standard pulse.el face" pulse-highlight-start-face)
+The default is `pulsar-generic' which reuses the standard face
+from the underlying pulse library.  Users can select one among
+`pulsar-red', `pulsar-green', `pulsar-yellow', `pulsar-blue',
+`pulsar-magenta', `pulsar-cyan', or any other face that has a
+background attribute."
+  :type '(radio (face :tag "Generic pulse.el face" pulsar-generic)
                 (face :tag "Red style" pulsar-red)
                 (face :tag "Green style" pulsar-green)
                 (face :tag "Yellow style" pulsar-yellow)
@@ -140,6 +141,11 @@ command is invoked."
   "Faces for `pulsar.el'."
   :group 'pulsar)
 
+(defface pulsar-generic
+  '((t :inherit pulse-highlight-start-face :extend t))
+  "Default value of `pulsar-face'."
+  :group 'pulsar-faces)
+
 (defface pulsar-red
   '((default :extend t)
     (((class color) (min-colors 88) (background light))