emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/git-commit 9fa3e4995e: magit-startup-asserts: Protect quot


From: ELPA Syncer
Subject: [nongnu] elpa/git-commit 9fa3e4995e: magit-startup-asserts: Protect quote in URL from styling
Date: Mon, 14 Mar 2022 23:58:05 -0400 (EDT)

branch: elpa/git-commit
commit 9fa3e4995ef160faf9e3b8587a958e94067b41f2
Author: Kyle Meyer <kyle@kyleam.com>
Commit: Kyle Meyer <kyle@kyleam.com>

    magit-startup-asserts: Protect quote in URL from styling
    
    Fixes #4633.
---
 lisp/magit.el | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/lisp/magit.el b/lisp/magit.el
index 08e9c6d502..50cebf5928 100644
--- a/lisp/magit.el
+++ b/lisp/magit.el
@@ -603,12 +603,18 @@ and Emacs to it."
 (defun magit-startup-asserts ()
   (when-let ((val (getenv "GIT_DIR")))
     (setenv "GIT_DIR")
-    (message "Magit unset $GIT_DIR (was %S).  See \
-https://github.com/magit/magit/wiki/Don't-set-$GIT_DIR-and-alike" val))
+    (message
+     "Magit unset $GIT_DIR (was %S).  See %s" val
+     ;; Note: Pass URL as argument rather than embedding in the format
+     ;; string to prevent the single quote from being rendered
+     ;; according to `text-quoting-style'.
+     "https://github.com/magit/magit/wiki/Don't-set-$GIT_DIR-and-alike"))
   (when-let ((val (getenv "GIT_WORK_TREE")))
     (setenv "GIT_WORK_TREE")
-    (message "Magit unset $GIT_WORK_TREE (was %S).  See \
-https://github.com/magit/magit/wiki/Don't-set-$GIT_DIR-and-alike" val))
+    (message
+     "Magit unset $GIT_WORK_TREE (was %S).  See %s" val
+     ;; See comment above.
+     "https://github.com/magit/magit/wiki/Don't-set-$GIT_DIR-and-alike"))
   ;; Git isn't required while building Magit.
   (cl-eval-when (load eval)
     (magit-git-version-assert))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]