emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/orderless 41281fd92d 1/2: Ivy: Do not auto register the


From: ELPA Syncer
Subject: [elpa] externals/orderless 41281fd92d 1/2: Ivy: Do not auto register the highlighting function
Date: Sat, 12 Mar 2022 14:57:36 -0500 (EST)

branch: externals/orderless
commit 41281fd92dbf6ab6dcf75f61312d8a486a7b4ca9
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>

    Ivy: Do not auto register the highlighting function
    
    It seems to me that there is almost no advantage of auto loading that part 
of
    the code in contrast to adding it to the configuration directly. Probably 
most
    users use Orderless with completion systems like default completion, 
Vertico or
    Mct.
---
 README.org     | 1 +
 orderless.el   | 6 ------
 orderless.texi | 1 +
 3 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/README.org b/README.org
index 71e3416270..a508befa1c 100644
--- a/README.org
+++ b/README.org
@@ -330,6 +330,7 @@ To use =orderless= from Ivy add this to your Ivy 
configuration:
 
 #+begin_src emacs-lisp
   (setq ivy-re-builders-alist '((t . orderless-ivy-re-builder)))
+  (add-to-list 'ivy-highlight-functions-alist '(orderless-ivy-re-builder . 
orderless-ivy-highlight))
 #+end_src
 
 ** Selectrum
diff --git a/orderless.el b/orderless.el
index 6352697247..347392f2d3 100644
--- a/orderless.el
+++ b/orderless.el
@@ -504,11 +504,5 @@ a value in `ivy-re-builders-alist'."
 This function is for integration of orderless with ivy."
   (orderless--highlight (mapcar #'car ivy-regex) str) str)
 
-;;;###autoload
-(with-eval-after-load 'ivy
-  (defvar ivy-highlight-functions-alist)
-  (add-to-list 'ivy-highlight-functions-alist
-               '(orderless-ivy-re-builder . orderless-ivy-highlight)))
-
 (provide 'orderless)
 ;;; orderless.el ends here
diff --git a/orderless.texi b/orderless.texi
index 9bafc7f83a..92d6d5771d 100644
--- a/orderless.texi
+++ b/orderless.texi
@@ -393,6 +393,7 @@ To use @samp{orderless} from Ivy add this to your Ivy 
configuration:
 
 @lisp
 (setq ivy-re-builders-alist '((t . orderless-ivy-re-builder)))
+(add-to-list 'ivy-highlight-functions-alist '(orderless-ivy-re-builder . 
orderless-ivy-highlight))
 @end lisp
 
 @node Selectrum



reply via email to

[Prev in Thread] Current Thread [Next in Thread]