emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/phps-mode 67c3beb075 12/15: Added TODO item for failing


From: Christian Johansson
Subject: [elpa] externals/phps-mode 67c3beb075 12/15: Added TODO item for failing indentation
Date: Fri, 4 Mar 2022 14:13:04 -0500 (EST)

branch: externals/phps-mode
commit 67c3beb075708904c89864a08bd7135d16e43fcf
Author: Christian Johansson <christian@cvj.se>
Commit: Christian Johansson <christian@cvj.se>

    Added TODO item for failing indentation
---
 test/phps-mode-test-indent.el | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/test/phps-mode-test-indent.el b/test/phps-mode-test-indent.el
index d899b065ce..ede8b5933d 100644
--- a/test/phps-mode-test-indent.el
+++ b/test/phps-mode-test-indent.el
@@ -165,6 +165,15 @@
         (phps-mode-indent--get-previous-reference-command-line)
         "    $variable =")))
 
+    ;; TODO Make this pass
+    (with-temp-buffer
+      (insert "<?php\n\nif (true) {\n    $valid = true;\n    $variable = 
myFunction();\n    switch ($variable) {\n        case Object::CASE1:\n          
  throw new Exception(\n                'MyException'\n            );\n        
case Object::Case2:\n            throw new \\Exception(\n                
'MyException2',\n            );\n        case Object::Case3:\n            
$valid = false;\n            break;\n        case Object::Case4:\n            
if (!Object2::validate($variable))  [...]
+      (goto-char 380)
+      (should
+       (string=
+        (phps-mode-indent--get-previous-reference-command-line)
+        "            $valid = false;")))
+
   (with-temp-buffer
     (insert "<?php\nif (true) {\n    array(\n        8,\n    );")
     (goto-char (point-max))
@@ -772,17 +781,14 @@
    "<?php\n$var = Object->myMethod()\n    ->myMethod2();\necho 'here';"
    "Line after assignment were an chaining of object methods started")
 
-  ;; TODO Make this pass
   (phps-mode-test-indent--should-equal
    "<?php\nif (true) {\n    $table = $installer->getConnection()\n        
->newTable($installer->getTable('my_table'))\n        ->addColumn();\n}\n"
    "Variable assignment with chained method calls on multiple lines #1")
 
-  ;; TODO Make this pass
   (phps-mode-test-indent--should-equal
    "<?php\nif (true) {\n    $criteria = $this->searchCriteriaBuilder\n        
->addFilter('status', $status)\n        ->addFilter(method', 'my_method_' . 
$object->getId())\n        ->create();\n}\n"
    "Variable assignment with chained method calls on multiple lines #2")
 
-  ;; TODO Make this pass
   (phps-mode-test-indent--should-equal
    "<?php\nif (true) {\n    /*\n    was here\n    */\n    echo 'there';\n}"
    "Line after closing multi-row comment")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]