[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/phps-mode 67c3beb075 12/15: Added TODO item for failing
From: |
Christian Johansson |
Subject: |
[elpa] externals/phps-mode 67c3beb075 12/15: Added TODO item for failing indentation |
Date: |
Fri, 4 Mar 2022 14:13:04 -0500 (EST) |
branch: externals/phps-mode
commit 67c3beb075708904c89864a08bd7135d16e43fcf
Author: Christian Johansson <christian@cvj.se>
Commit: Christian Johansson <christian@cvj.se>
Added TODO item for failing indentation
---
test/phps-mode-test-indent.el | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/test/phps-mode-test-indent.el b/test/phps-mode-test-indent.el
index d899b065ce..ede8b5933d 100644
--- a/test/phps-mode-test-indent.el
+++ b/test/phps-mode-test-indent.el
@@ -165,6 +165,15 @@
(phps-mode-indent--get-previous-reference-command-line)
" $variable =")))
+ ;; TODO Make this pass
+ (with-temp-buffer
+ (insert "<?php\n\nif (true) {\n $valid = true;\n $variable =
myFunction();\n switch ($variable) {\n case Object::CASE1:\n
throw new Exception(\n 'MyException'\n );\n
case Object::Case2:\n throw new \\Exception(\n
'MyException2',\n );\n case Object::Case3:\n
$valid = false;\n break;\n case Object::Case4:\n
if (!Object2::validate($variable)) [...]
+ (goto-char 380)
+ (should
+ (string=
+ (phps-mode-indent--get-previous-reference-command-line)
+ " $valid = false;")))
+
(with-temp-buffer
(insert "<?php\nif (true) {\n array(\n 8,\n );")
(goto-char (point-max))
@@ -772,17 +781,14 @@
"<?php\n$var = Object->myMethod()\n ->myMethod2();\necho 'here';"
"Line after assignment were an chaining of object methods started")
- ;; TODO Make this pass
(phps-mode-test-indent--should-equal
"<?php\nif (true) {\n $table = $installer->getConnection()\n
->newTable($installer->getTable('my_table'))\n ->addColumn();\n}\n"
"Variable assignment with chained method calls on multiple lines #1")
- ;; TODO Make this pass
(phps-mode-test-indent--should-equal
"<?php\nif (true) {\n $criteria = $this->searchCriteriaBuilder\n
->addFilter('status', $status)\n ->addFilter(method', 'my_method_' .
$object->getId())\n ->create();\n}\n"
"Variable assignment with chained method calls on multiple lines #2")
- ;; TODO Make this pass
(phps-mode-test-indent--should-equal
"<?php\nif (true) {\n /*\n was here\n */\n echo 'there';\n}"
"Line after closing multi-row comment")
- [elpa] externals/phps-mode updated (35870e4cb1 -> 3349852f21), Christian Johansson, 2022/03/04
- [elpa] externals/phps-mode f494fde442 06/15: Added TODO-item, Christian Johansson, 2022/03/04
- [elpa] externals/phps-mode 5fbc73bd43 01/15: Added TODO case, Christian Johansson, 2022/03/04
- [elpa] externals/phps-mode 027b102d71 04/15: Added failing indentation tests, Christian Johansson, 2022/03/04
- [elpa] externals/phps-mode b5f38a926f 05/15: More work on indentation around multi-line chained objects, Christian Johansson, 2022/03/04
- [elpa] externals/phps-mode 0c9d4d7fe9 08/15: Passing test for indenting multi-line chaining expressions, Christian Johansson, 2022/03/04
- [elpa] externals/phps-mode fd36f650e6 10/15: Added TODO items, Christian Johansson, 2022/03/04
- [elpa] externals/phps-mode 67c3beb075 12/15: Added TODO item for failing indentation,
Christian Johansson <=
- [elpa] externals/phps-mode f7f8ea26b1 02/15: Improved cache writing method, Christian Johansson, 2022/03/04
- [elpa] externals/phps-mode 9a852fd48e 03/15: Added another failing indentation case, Christian Johansson, 2022/03/04
- [elpa] externals/phps-mode 8d77fbdfdb 13/15: Improved indentation around switch case branches, Christian Johansson, 2022/03/04
- [elpa] externals/phps-mode d1d1d4b9a7 14/15: Updated version and modified date, Christian Johansson, 2022/03/04
- [elpa] externals/phps-mode 9ac4797803 09/15: Passed indentation test for line after comment block, Christian Johansson, 2022/03/04
- [elpa] externals/phps-mode 5d420ba200 11/15: Formatted TODO-items better, Christian Johansson, 2022/03/04
- [elpa] externals/phps-mode 3349852f21 15/15: Added TODO item, Christian Johansson, 2022/03/04
- [elpa] externals/phps-mode f619fe6911 07/15: Started on helper function for calculating indentation for multi-line chaining expressions, Christian Johansson, 2022/03/04