emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/svg-lib 153d13c634 1/3: [refactor] Use `when` and `unle


From: ELPA Syncer
Subject: [elpa] externals/svg-lib 153d13c634 1/3: [refactor] Use `when` and `unless` and 2 other minor things
Date: Thu, 3 Mar 2022 09:57:57 -0500 (EST)

branch: externals/svg-lib
commit 153d13c634aa4af19a7f243006b89cde343f7bc0
Author: aru-hackZ <aru_hackZ.official@zohomail.eu>
Commit: aru-hackZ <aru_hackZ.official@zohomail.eu>

    [refactor] Use `when` and `unless` and 2 other minor things
    
    Use `when` when there is no else part in an `if`.
    When the above is applied, use `unless` if you have a
    `(when (not cond) (stuff))` which would look `(unless cond (stuff))`.
    Also removing unnecessary `if` and aligning the else part of an `if`.
---
 svg-lib.el | 40 ++++++++++++++++++++--------------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/svg-lib.el b/svg-lib.el
index c4aca0c779..5c955e0dac 100644
--- a/svg-lib.el
+++ b/svg-lib.el
@@ -87,8 +87,8 @@
 (require 'color)
 
 ;; Check if Emacs has been compiled with svg support
-(if (not (image-type-available-p 'svg))
-    (error "svg-lib.el requires Emacs to be compiled with svg support.\n"))
+(unless (image-type-available-p 'svg)
+  (error "svg-lib.el requires Emacs to be compiled with svg support.\n"))
 
 
 (defgroup svg-lib nil
@@ -244,7 +244,7 @@ and style elements ARGS."
          (txt-char-height (window-font-height))
          (txt-char-height (if line-spacing
                               (+ txt-char-height line-spacing)
-                          txt-char-height))
+                            txt-char-height))
          (font-info       (font-info (format "%s-%d" font-family font-size)))
          (ascent          (aref font-info 8))
          (tag-char-width  (aref font-info 11))
@@ -267,9 +267,9 @@ and style elements ARGS."
          
          (svg (svg-create svg-width svg-height)))
 
-    (if (>= stroke 0.25)
-        (svg-rectangle svg tag-x 0 tag-width tag-height
-                           :fill foreground :rx radius))
+    (when (>= stroke 0.25)
+      (svg-rectangle svg tag-x 0 tag-width tag-height
+                     :fill foreground :rx radius))
     (svg-rectangle svg (+ tag-x (/ stroke 2.0)) (/ stroke 2.0)
                        (- tag-width stroke) (- tag-height stroke)
                        :fill background :rx (- radius (/ stroke 2.0)))
@@ -330,11 +330,11 @@ and style elements ARGS."
          (x1              (+ cx (* iradius (cos angle1))))
          (y1              (+ cy (* iradius (sin angle1))))
 
-         (large-arc       (if (>= (- angle1 angle0) pi) t nil))
+         (large-arc       (>= (- angle1 angle0) pi))
          (svg (svg-create svg-width svg-height)))
 
-    (if (>= stroke 0.25)
-        (svg-circle svg cx cy radius :fill foreground))
+    (when (>= stroke 0.25)
+      (svg-circle svg cx cy radius :fill foreground))
 
     (svg-circle svg cx cy (- radius (/ stroke 2.0)) :fill background)
 
@@ -388,9 +388,9 @@ and style elements ARGS."
          (tag-x (/ (- svg-width tag-width) 2))
          (svg (svg-create svg-width svg-height)))
 
-    (if (>= stroke 0.25)
-        (svg-rectangle svg tag-x 0 tag-width tag-height
-                       :fill foreground :rx radius))
+    (when (>= stroke 0.25)
+      (svg-rectangle svg tag-x 0 tag-width tag-height
+                     :fill foreground :rx radius))
     (svg-rectangle svg (+ tag-x (/ stroke 2.0))
                        (/ stroke 2.0)
                        (- tag-width stroke)
@@ -483,9 +483,9 @@ given STYLE and style elements ARGS."
 
          (svg (svg-create svg-width svg-height)))
 
-    (if (>= stroke 0.25)
-        (svg-rectangle svg box-x box-y box-width box-height
-                       :fill foreground :rx radius))
+    (when (>= stroke 0.25)
+      (svg-rectangle svg box-x box-y box-width box-height
+                     :fill foreground :rx radius))
     (svg-rectangle svg (+ box-x (/ stroke 2.0))
                        (+ box-y (/ stroke 2.0))
                        (- box-width stroke)
@@ -568,9 +568,9 @@ and style elements ARGS."
                   (- (/ svg-height 2 scale) (/ icon-height 2))))
          (svg (svg-create svg-width svg-height)))
 
-    (if (>= stroke 0.25)
-        (svg-rectangle svg tag-x 0 tag-width tag-height
-                           :fill foreground :rx radius))
+    (when (>= stroke 0.25)
+      (svg-rectangle svg tag-x 0 tag-width tag-height
+                     :fill foreground :rx radius))
     (svg-rectangle svg (+ tag-x (/ stroke 2.0)) (/ stroke 2.0)
                        (- tag-width stroke) (- tag-height stroke)
                        :fill background :rx (- radius (/ stroke 2.0)))
@@ -619,8 +619,8 @@ and style elements ARGS."
      (dom-append-child svg child))
 
    (dolist (child children-2)
-     (if (not (stringp child))
-         (dom-set-attribute child 'transform transform))
+     (unless (stringp child)
+       (dom-set-attribute child 'transform transform))
      (dom-append-child svg child))
    svg))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]