emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/vertico 2de617a919: add-hook/remove-hook has a serious


From: ELPA Syncer
Subject: [elpa] externals/vertico 2de617a919: add-hook/remove-hook has a serious issue where the hook--depth-alist is not cleaned up
Date: Tue, 22 Feb 2022 07:57:57 -0500 (EST)

branch: externals/vertico
commit 2de617a9199d152533ce280c6eb653147f15f8d1
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>

    add-hook/remove-hook has a serious issue where the hook--depth-alist is not 
cleaned up
    
    Stop using hook priorities everywhere until this is fixed.
---
 vertico.el | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/vertico.el b/vertico.el
index 0350f5e539..c5d2588a7a 100644
--- a/vertico.el
+++ b/vertico.el
@@ -753,10 +753,7 @@ When the prefix argument is 0, the group order is reset."
   (setq-local completion-auto-help nil
               completion-show-inline-help nil)
   (use-local-map vertico-map)
-  ;; Use -90 to ensure that the exhibit hook runs early such that the
-  ;; candidates are available for Consult preview. It works, but besides
-  ;; that I'dont have a specific reason for this particular value.
-  (add-hook 'post-command-hook #'vertico--exhibit -90 'local))
+  (add-hook 'post-command-hook #'vertico--exhibit nil 'local))
 
 (defun vertico--advice (&rest args)
   "Advice for completion function, receiving ARGS."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]