emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/typescript-mode 0d32c85bfb 110/222: Drop typescript-parent


From: ELPA Syncer
Subject: [nongnu] elpa/typescript-mode 0d32c85bfb 110/222: Drop typescript-parent-mode.
Date: Sun, 6 Feb 2022 16:59:23 -0500 (EST)

branch: elpa/typescript-mode
commit 0d32c85bfb3de1312f0fc0e591facdf9077192e7
Author: Louis-Dominique Dubeau <ldd@lddubeau.com>
Commit: Louis-Dominique Dubeau <ldd@lddubeau.com>

    Drop typescript-parent-mode.
    
    Fixes #75.
    
    Copying some of the discussion from the issue thread:
    
    "If I run `git blame` on the code, I see that setup dates from the
    initial commit and so was probably inherited from `js-mode`. If I look
    at the current `js-mode` bundled with my Emacs, however, there's no
    such equivalent indirection there. Searching through Emacs's commits,
    I see `prog-mode` was added to Emacs 24.1 (which dates from 2012
    according to Wikipedia). So I guess if `typescript-mode` is to be used
    with versions of Emacs *older than that*, it needs to be able to fall
    back on `fundamental-mode`, but do we need to support versions that
    old?"
    
    (No, we don't.)
---
 typescript-mode.el | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/typescript-mode.el b/typescript-mode.el
index 17d64538d7..11627ab412 100644
--- a/typescript-mode.el
+++ b/typescript-mode.el
@@ -2585,11 +2585,8 @@ the broken-down class name of the item to insert."
 
 ;;; Main Function
 
-(defalias 'typescript-parent-mode
-  (if (fboundp 'prog-mode) 'prog-mode 'fundamental-mode))
-
 ;;;###autoload
-(define-derived-mode typescript-mode typescript-parent-mode "typescript"
+(define-derived-mode typescript-mode prog-mode "typescript"
   "Major mode for editing typescript.
 
 Key bindings:



reply via email to

[Prev in Thread] Current Thread [Next in Thread]