[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/elpher 09f4d52c0f 2/2: Fixed issues flagged by flycheck.
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/elpher 09f4d52c0f 2/2: Fixed issues flagged by flycheck. |
Date: |
Wed, 2 Feb 2022 07:57:59 -0500 (EST) |
branch: elpa/elpher
commit 09f4d52c0f3ff9cdd4fbddbdc513c42f6650918a
Author: plugd <plugd@thelambdalab.xyz>
Commit: plugd <plugd@thelambdalab.xyz>
Fixed issues flagged by flycheck.
Issues included:
1. Missing documentation on elpher-build-current-imenu-index
2. Variable referenced out of scope in elpher-gemini-insert-link
This second issue has been around for a while, but never caused
problems because the particular statement was unreachable. The
patch simply removes the unreachable code.
---
config.mk | 2 +-
elpher-pkg.el | 2 +-
elpher.el | 34 +++++++++++++++++-----------------
3 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/config.mk b/config.mk
index 859a67b15b..864000aad0 100644
--- a/config.mk
+++ b/config.mk
@@ -1,5 +1,5 @@
PKG = elpher
-VERSION = 3.3.0
+VERSION = 3.3.1
INSTALLINFO = install-info
MAKEINFO = makeinfo
diff --git a/elpher-pkg.el b/elpher-pkg.el
index 894eb3b6da..9ce54631b0 100644
--- a/elpher-pkg.el
+++ b/elpher-pkg.el
@@ -1,4 +1,4 @@
-(define-package "elpher" "3.3.0" "A friendly gopher and gemini client"
+(define-package "elpher" "3.3.1" "A friendly gopher and gemini client"
'((emacs "27.1"))
:keywords ("convenience")
:authors (("Tim Vaughan" . "plugd@thelambdalab.xyz"))
diff --git a/elpher.el b/elpher.el
index 3145d69eba..a869b6a880 100644
--- a/elpher.el
+++ b/elpher.el
@@ -5,7 +5,7 @@
;; Author: Tim Vaughan <plugd@thelambdalab.xyz>
;; Created: 11 April 2019
-;; Version: 3.3.0
+;; Version: 3.3.1
;; Keywords: comm gopher
;; Homepage: https://thelambdalab.xyz/elpher
;; Package-Requires: ((emacs "27.1"))
@@ -70,7 +70,7 @@
;;; Global constants
;;
-(defconst elpher-version "3.3.0"
+(defconst elpher-version "3.3.1"
"Current version of elpher.")
(defconst elpher-margin-width 6
@@ -1506,21 +1506,20 @@ treatment that a separate function is warranted."
(type (if address (elpher-address-type address) nil))
(type-map-entry (cdr (assoc type elpher-type-map)))
(fill-prefix (make-string (+ 1 (length
elpher-gemini-link-string)) ?\s)))
- (insert elpher-gemini-link-string)
- (if type-map-entry
- (let* ((face (elt type-map-entry 3))
- (display-string (or given-display-string
- (elpher-address-to-iri address)))
- (page (elpher-make-page display-string
- address)))
- (insert-text-button display-string
- 'face face
- 'elpher-page page
- 'action #'elpher-click-link
- 'follow-link t
- 'help-echo #'elpher--page-button-help))
- (insert (propertize display-string 'face 'elpher-unknown)))
- (newline)))))
+ (when type-map-entry
+ (insert elpher-gemini-link-string)
+ (let* ((face (elt type-map-entry 3))
+ (display-string (or given-display-string
+ (elpher-address-to-iri address)))
+ (page (elpher-make-page display-string
+ address)))
+ (insert-text-button display-string
+ 'face face
+ 'elpher-page page
+ 'action #'elpher-click-link
+ 'follow-link t
+ 'help-echo #'elpher--page-button-help))
+ (newline))))))
(defun elpher-gemini-insert-header (header-line)
"Insert header described by HEADER-LINE into a text/gemini document.
@@ -1605,6 +1604,7 @@ width defined by `elpher-gemini-max-fill-width'."
(buffer-string))))
(defun elpher-build-current-imenu-index ()
+ "Build imenu index for current elpher buffer."
(save-excursion
(goto-char (point-min))
(let ((match nil)