emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/graphql-mode f3cfd9fc1e 062/122: Don't send the query as a


From: ELPA Syncer
Subject: [nongnu] elpa/graphql-mode f3cfd9fc1e 062/122: Don't send the query as a query parameter
Date: Sat, 29 Jan 2022 08:03:33 -0500 (EST)

branch: elpa/graphql-mode
commit f3cfd9fc1e458ecc37fc90738e5bdaf084d5d433
Author: David Vázquez Púa <davazp@gmail.com>
Commit: David Vázquez Púa <davazp@gmail.com>

    Don't send the query as a query parameter
    
    The query is sent in the post body, so shouldn't be included
    additionally in the query parameter.
---
 graphql-mode.el | 27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/graphql-mode.el b/graphql-mode.el
index 67d59b2b45..9d57d0918c 100644
--- a/graphql-mode.el
+++ b/graphql-mode.el
@@ -87,8 +87,9 @@ mutation or subscription).  OPERATION is a name for the
 operation.  VARIABLES is the JSON string that specifies the values
 of the variables used in the query."
   (let* ((body (graphql-encode-json query operation variables))
-        (url (format "%s?query=%s" graphql-url (url-encode-url body))))
-    (with-temp-buffer (graphql-post-request url query operation variables))))
+         (url graphql-url))
+    (with-temp-buffer
+      (graphql-post-request url query operation variables))))
 
 (defun graphql-post-request (url query &optional operation variables)
   "Make post request to graphql server with url and body.
@@ -98,18 +99,16 @@ QUERY query definition(s) of query, mutation, and/or 
subscription
 OPERATION name of the operation if multiple definition is given in QUERY
 VARIABLES list of variables for query operation"
   (let* ((body (graphql-encode-json query operation variables))
-        (endpoint (car (split-string url "?")))
-        (response (request
-                    url
-                    :type "POST"
-                    :data body
-                    :headers '(("Content-Type" . "application/json"))
-                    :parser 'json-read
-                    :sync t
-                    :complete (lambda (&rest _)
-                                (message "%s" (if (string-equal "" operation)
-                                                  endpoint
-                                                (format "%s?operationName=%s" 
endpoint operation)))))))
+         (response (request url
+                            :type "POST"
+                            :data body
+                            :headers '(("Content-Type" . "application/json"))
+                            :parser 'json-read
+                            :sync t
+                            :complete (lambda (&rest _)
+                                        (message "%s" (if (string-equal "" 
operation)
+                                                          url
+                                                        (format 
"%s?operationName=%s" endpoint operation)))))))
     (json-encode (request-response-data response))))
 
 (defun graphql-beginning-of-query ()



reply via email to

[Prev in Thread] Current Thread [Next in Thread]