emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/dockerfile-mode 3f460b6de0 003/104: Error check docker-ima


From: ELPA Syncer
Subject: [nongnu] elpa/dockerfile-mode 3f460b6de0 003/104: Error check docker-image-name and give helpful error message
Date: Sat, 29 Jan 2022 07:58:15 -0500 (EST)

branch: elpa/dockerfile-mode
commit 3f460b6de03438ba7db120a29ce0404b7749a1ec
Author: Drew Csillag <drewc@spotify.com>
Commit: Drew Csillag <drewc@spotify.com>

    Error check docker-image-name and give helpful error message
---
 dockerfile-mode.el | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/dockerfile-mode.el b/dockerfile-mode.el
index 1dc5460ce1..ad648380c0 100644
--- a/dockerfile-mode.el
+++ b/dockerfile-mode.el
@@ -71,10 +71,11 @@
       (list (read-string "image-name:" nil nil))
      (list docker-image-name)))
   (save-buffer)
-  (shell-command
-   (concat "docker build -t " image-name " " (file-name-directory 
(buffer-file-name)) "&")
-   "*docker-build-output*")
-  (switch-to-buffer "*docker-build-output*"))
+  (if (stringp image-name)
+      (shell-command
+       (concat "docker build -t " image-name " " (file-name-directory 
(buffer-file-name)) "&")
+       "*docker-build-output*")
+    (print "docker-image-name must be a string, consider surrounding it with 
double quotes")))
 
 ;;;###autoload
 (defun dockerfile-mode ()
@@ -99,3 +100,4 @@
   (run-mode-hooks 'dockerfile-mode-hook))
 
 (provide 'dockerfile-mode)
+



reply via email to

[Prev in Thread] Current Thread [Next in Thread]