[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/org-remark 067681278f 038/173: fix: next/prev was rever
From: |
ELPA Syncer |
Subject: |
[elpa] externals/org-remark 067681278f 038/173: fix: next/prev was reversed |
Date: |
Fri, 28 Jan 2022 16:57:57 -0500 (EST) |
branch: externals/org-remark
commit 067681278fed0313c201f60d8ff4b1f7ca8b54c0
Author: Noboru Ota <me@nobiot.com>
Commit: Noboru Ota <me@nobiot.com>
fix: next/prev was reversed
mapcar keeps the original order, but dolist + push reverses the order of the
resultant list. dolist was used in order to eliminate `nil` elements as
mapcar
keeps it (it should, as the number of elements should be identical for
map). Now the `nil` is removed with fn `remove`; to me this more intuitive
than dolist.
---
org-marginalia.el | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/org-marginalia.el b/org-marginalia.el
index 7e64e1b268..2848814cb1 100644
--- a/org-marginalia.el
+++ b/org-marginalia.el
@@ -481,14 +481,13 @@ visible ones.
If none, return nil."
(when om/highlights
- (let ((list '()))
- (dolist (h om/highlights)
- (org-with-wide-buffer
- (let ((p (marker-position (car (cdr h)))))
- (unless (car (get-char-property-and-overlay p 'invisible))
- (push p list)))))
- (when list
- (if reverse (reverse list) list)))))
+ (when om/highlights
+ (let ((list (mapcar (lambda (h)
+ (marker-position (car (cdr h))))
+ om/highlights)))
+ (remove nil list)
+ (when list
+ (if reverse (reverse list) list))))))
(defun om/sort-highlights-list ()
"Utility function to sort `om/sort-highlights'."
- [elpa] externals/org-remark 82a4afbee0 169/173: add: delete with confirmation promt etc., (continued)
- [elpa] externals/org-remark 82a4afbee0 169/173: add: delete with confirmation promt etc., ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark a1ff9033c1 170/173: add: org-remark-delete, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark dc162bc8ec 172/173: fix: window management for open and remove/delete, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark 91d7583495 065/173: add: mark deactivate-mark & set-buffer-modified-p, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark bd01afe043 068/173: add tracking: customizing subgroup, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark 0e2a215c40 079/173: readme, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark bc051adab9 022/173: doc: Add some clarification to readme, etc., ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark 1878b9ddce 029/173: fix: Error narrowed source for range, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark 310b79efc5 033/173: doc: Add a limitatino of moving files, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark 6bfac5368e 036/173: intrnl: Add eval org-marginalia-mode to file var, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark 067681278f 038/173: fix: next/prev was reversed,
ELPA Syncer <=
- [elpa] externals/org-remark b595c74a06 045/173: doc: Update docstring for the sort fn, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark 9e2341a51f 049/173: [doc] fix code example, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark 1ac1f2555b 050/173: Update README.org, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark e6bf242649 058/173: fix: Add highlighter face def for termianl, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark 0dd01e91ec 060/173: fix: org-id-uuid is not found, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark 1ce0a7dc31 061/173: add: org-marginalia-remove can take C-u to delete, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark e4927186ef 063/173: feat: global auto-tracking, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark b62c6b3de4 072/173: readme, ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark 6b0bbad4b3 070/173: feat: link with org-id (WIP), ELPA Syncer, 2022/01/28
- [elpa] externals/org-remark a9acfcd106 077/173: doc: README for 0.0.6, ELPA Syncer, 2022/01/28