emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/phps-mode 491c82a2a1 071/212: Added TODO item for bookk


From: Christian Johansson
Subject: [elpa] externals/phps-mode 491c82a2a1 071/212: Added TODO item for bookkeeping via AST
Date: Wed, 26 Jan 2022 01:50:51 -0500 (EST)

branch: externals/phps-mode
commit 491c82a2a1a7b10fdef6e16aa2c55db27aa43243
Author: Christian Johansson <christian@cvj.se>
Commit: Christian Johansson <christian@cvj.se>

    Added TODO item for bookkeeping via AST
---
 test/phps-mode-test-ast.el | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/test/phps-mode-test-ast.el b/test/phps-mode-test-ast.el
index 5dc91f03da..ab52402525 100644
--- a/test/phps-mode-test-ast.el
+++ b/test/phps-mode-test-ast.el
@@ -401,11 +401,14 @@
 
   (phps-mode-test-ast--should-bookkeep
    "<?php\nclass MyClass\n{\n    static function here()\n    {\n        if 
($this) {\n            // Miss;\n        }\n    }\n    function there()\n    
{\n        if ($this) {\n            // Hit\n        }\n    }\n}\n"
-   "Test variables available inside static function and method"
+   "Bookkeeping of $this not available inside static method"
    '(((68 73) 0) (" class MyClass function there id $this" 1) ((153 158) 1)))
 
-  ;; TODO Test this and make sure all variables hit
-  ;; class myClass { private $test = 'abc'; public function test($d) { return 
fn($d) => $this->test . $d; }} $a = new myClass(); echo $a->test('def')('ghi');
+  ;; TODO Make this test work and pass
+  (phps-mode-test-ast--should-bookkeep
+   "<?php\n\nclass myClass\n{\n    private $test = 'abc';\n    public function 
test($d)\n    {\n        return fn($e) => $this->test . $d . $e;\n    
}\n}\n\n$a = new myClass();\necho $a->test('def')('ghi');"
+   "Bookkeeping of $this reference inside arrow function inside of method"
+   '(0 1 2))
 
   (message "\n-- Ran tests for bookkeeping generation. --"))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]