[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/transient bf29731a72 332/366: transient--post-command:
From: |
Jonas Bernoulli |
Subject: |
[elpa] externals/transient bf29731a72 332/366: transient--post-command: Don't pop and push equal redisplay maps |
Date: |
Tue, 25 Jan 2022 18:54:52 -0500 (EST) |
branch: externals/transient
commit bf29731a721118ec1c1ed94f45e57ca67815550a
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
transient--post-command: Don't pop and push equal redisplay maps
`set-transient-map' arranges for the exit function not to be called
if another transient map was added later. While we don't use that
function ourselves, this feature still backfires when we replace the
redisplay map, causing e.g. `mouse-drag-track's transient map to be
left in place when it should be removed.
---
lisp/transient.el | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lisp/transient.el b/lisp/transient.el
index 386d4d2ad3..478e32aaef 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -2100,9 +2100,12 @@ value. Otherwise return CHILDREN as is."
(transient--post-exit))
((eq this-command (oref transient--prefix command)))
(t
- (transient--pop-keymap 'transient--redisplay-map)
- (setq transient--redisplay-map (transient--make-redisplay-map))
- (transient--push-keymap 'transient--redisplay-map)
+ (let ((old transient--redisplay-map)
+ (new (transient--make-redisplay-map)))
+ (unless (equal old new)
+ (transient--pop-keymap 'transient--redisplay-map)
+ (setq transient--redisplay-map new)
+ (transient--push-keymap 'transient--redisplay-map)))
(transient--redisplay)))))
(defun transient--post-exit ()
- [elpa] externals/transient 9b6a251f5c 300/366: transient-show-help: Avoid this-original-command, (continued)
- [elpa] externals/transient 9b6a251f5c 300/366: transient-show-help: Avoid this-original-command, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 667488ebff 305/366: Extend multi-value support, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 202271f755 306/366: Resurrect transient-files class, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 4e8aa09b3f 309/366: transient-define-infix: Fix documentation, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient c26cbac574 316/366: transient-{init, set}-value: Use case-sensitive matching, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 338f7942a7 320/366: Various debug improvements, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 79c999d263 325/366: transient--post-exit: New function, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient e77d16dd02 322/366: transient--post-command: Avoid needlessly recreating redisplay map, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 7b8a7d718a 327/366: Use a more targeted approach to suspending transient override, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 3c78b10f52 333/366: transient--redisplay: Don't redisplay during mouse-drag-region, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient bf29731a72 332/366: transient--post-command: Don't pop and push equal redisplay maps,
Jonas Bernoulli <=
- [elpa] externals/transient 777a84d26b 339/366: manual: Document all options, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient c19ff84355 338/366: manual: Rearrange and group options, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 9412f26175 356/366: manual: Use more @itemx, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 3de8d9b256 357/366: manual: Fix list item, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient ecb815bcae 353/366: transient--abort-commands: Add keyboard-escape-quit, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 686b7ebc5f 363/366: Fix handling of sub-prefix command that use the minibuffer, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient cda6a12042 342/366: transient-align-variable-pitch: New option, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient a19faa1c71 364/366: Return to outer prefix when minibuffer is aborted for sub-prefix, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 994616d92f 365/366: manual: Fix version macro and prefer PACKAGE_REVDESC, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 3b4202e8ca 358/366: Silence byte-compiler, Jonas Bernoulli, 2022/01/25