[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/transient be119ee43f 278/366: Export variables for tran
From: |
Jonas Bernoulli |
Subject: |
[elpa] externals/transient be119ee43f 278/366: Export variables for transient non-infix suffixes |
Date: |
Tue, 25 Jan 2022 18:54:47 -0500 (EST) |
branch: externals/transient
commit be119ee43fe5f6af2469d366f6ab84204255038d
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
Export variables for transient non-infix suffixes
Unlike infixes, which change the value, non-infix suffixes are
supposed to use the value. Just because they are made transient,
that doesn't mean they should fall back to the default value and
have no access to other state variables that need to be exported.
It was clearly unintentional to use the non-exporting pre-command
for non-infix suffixes when the value of `transient' is just t.
Closes #151.
---
lisp/transient.el | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lisp/transient.el b/lisp/transient.el
index 4d1df2fcf3..abae5b770d 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -1611,9 +1611,10 @@ of the corresponding object.")
(define-key map (vector sym)
(let ((do (oref obj transient)))
(pcase do
- (`t (if sub-prefix
- 'transient--do-replace
- 'transient--do-stay))
+ (`t (cond (sub-prefix 'transient--do-replace)
+ ((cl-typep obj 'transient-infix)
+ 'transient--do-stay)
+ (t 'transient--do-call)))
(`nil 'transient--do-exit)
(_ do)))))
((not (lookup-key transient-predicate-map (vector sym)))
- [elpa] externals/transient d76f73f884 205/366: transient-arg-value: New function, (continued)
- [elpa] externals/transient d76f73f884 205/366: transient-arg-value: New function, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 0d79ccfaf8 218/366: transient--parse-suffix: Don't fallback to read-string for options, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 94582a3fd9 228/366: license: Update URLs and cleanup whitespace, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 6af9f8c3c0 254/366: Backport commit 12bab20920 from Emacs, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient b47e9d7d76 256/366: Release version 0.3.4, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient b711543401 261/366: Release version 0.3.5, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 99e48369a5 269/366: transient--invalid: Add heisenbug catcher, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient e90481000f 271/366: Explicitly call transient--pre-command in button action, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient efdf91980a 273/366: transient--goto-button: Anchor headings, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient e17e2b2f6d 276/366: transient-show-help: Tweak self-suffixes, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient be119ee43f 278/366: Export variables for transient non-infix suffixes,
Jonas Bernoulli <=
- [elpa] externals/transient 022f20e958 283/366: Explicitly require edmacro, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 09c911e621 299/366: transient--show-manual: New function, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 222637523a 302/366: transient-show-help: Refactor and improve, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient c9ab648e5b 304/366: transient--show-help: Update doc-strings, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 349116159f 308/366: manual: Use Org macros, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient e57d1e176b 313/366: make: Cosmetics, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient daa22e7632 317/366: manual: Downcase keywords, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 1cdadfddf8 340/366: manual: Use source block, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient c2875e705a 362/366: transient--delay-post-command: Add debug statement, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient e0b57679f7 359/366: transient--debug: Re-align output, Jonas Bernoulli, 2022/01/25