[elpa] externals/transient ae2574ba70 143/366: transient--show: Don't show thin line without window system

[Jonas Bernoulli]

branch: externals/transient
commit ae2574ba700cc12f3b613117fbece5daff30ecc3
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    transient--show: Don't show thin line without window system
    
    It won't work and display a fat line instead.  We have to decide this
    every time this function is called because there can be termcap and
    window system frames in the same Emacs session.
---
 docs/transient.org  | 7 ++++---
 docs/transient.texi | 7 ++++---
 lisp/transient.el   | 8 +++++---
 3 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/docs/transient.org b/docs/transient.org
index d9cc82e445..f6549e05c7 100644
--- a/docs/transient.org
+++ b/docs/transient.org
@@ -8,7 +8,7 @@
 #+TEXINFO_DIR_CATEGORY: Emacs
 #+TEXINFO_DIR_TITLE: Transient: (transient).
 #+TEXINFO_DIR_DESC: Transient Commands
-#+SUBTITLE: for version 0.1.0 (v0.1.0-134-g83cb1e4+1)
+#+SUBTITLE: for version 0.1.0 (v0.1.0-141-g5c0f901+1)
 
 #+TEXINFO_DEFFN: t
 #+OPTIONS: H:4 num:4 toc:2
@@ -37,7 +37,7 @@ Calling a suffix command usually causes the transient to be 
exited
 but suffix commands can also be configured to not exit the transient.
 
 #+TEXINFO: @noindent
-This manual is for Transient version 0.1.0 (v0.1.0-134-g83cb1e4+1).
+This manual is for Transient version 0.1.0 (v0.1.0-141-g5c0f901+1).
 
 #+BEGIN_QUOTE
 Copyright (C) 2018-2020 Jonas Bernoulli <jonas@bernoul.li>
@@ -548,7 +548,8 @@ window, and the key bindings are the same as for 
~scroll-up-command~ and
 
   If ~line~ (the default), then the buffer also has no mode-line, but a
   thin line is drawn instead, using the background color of the face
-  ~transient-separator~.
+  ~transient-separator~.  Termcap frames cannot display thin lines and
+  therefore fallback to treating ~line~ like ~nil~.
 
   Otherwise this can be any mode-line format.  See [[info:elisp#Mode
   Line Format]] for details.
diff --git a/docs/transient.texi b/docs/transient.texi
index adad7f4d3c..174b74e0d8 100644
--- a/docs/transient.texi
+++ b/docs/transient.texi
@@ -31,7 +31,7 @@ General Public License for more details.
 @finalout
 @titlepage
 @title Transient User and Developer Manual
-@subtitle for version 0.1.0 (v0.1.0-134-g83cb1e4+1)
+@subtitle for version 0.1.0 (v0.1.0-141-g5c0f901+1)
 @author Jonas Bernoulli
 @page
 @vskip 0pt plus 1filll
@@ -65,7 +65,7 @@ Calling a suffix command usually causes the transient to be 
exited
 but suffix commands can also be configured to not exit the transient.
 
 @noindent
-This manual is for Transient version 0.1.0 (v0.1.0-134-g83cb1e4+1).
+This manual is for Transient version 0.1.0 (v0.1.0-141-g5c0f901+1).
 
 @quotation
 Copyright (C) 2018-2020 Jonas Bernoulli <jonas@@bernoul.li>
@@ -735,7 +735,8 @@ good value.
 
 If @code{line} (the default), then the buffer also has no mode-line, but a
 thin line is drawn instead, using the background color of the face
-@code{transient-separator}.
+@code{transient-separator}.  Termcap frames cannot display thin lines and
+therefore fallback to treating @code{line} like @code{nil}.
 
 Otherwise this can be any mode-line format.  See @ref{Mode Line 
Format,,,elisp,} for details.
 @end defopt
diff --git a/lisp/transient.el b/lisp/transient.el
index 07ec73e5fe..54ff80d6ab 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -141,7 +141,7 @@ want to change the value of `transient-mode-line-format'."
   :type '(cons (choice function (repeat :tag "Functions" function))
                alist))
 
-(defcustom transient-mode-line-format (and window-system 'line)
+(defcustom transient-mode-line-format 'line
   "The mode-line format for the transient popup buffer.
 
 If nil, then the buffer has no mode-line.  If the buffer is not
@@ -150,7 +150,8 @@ a good value.
 
 If `line' (the default), then the buffer also has no mode-line,
 but a thin line is drawn instead, using the background color of
-the face `transient-separator'.
+the face `transient-separator'.  Termcap frames cannot display
+thin lines and therefore fallback to treating `line' like nil.
 
 Otherwise this can be any mode-line format.
 See `mode-line-format' for details."
@@ -2543,7 +2544,8 @@ have a history of their own.")
       (transient--insert-groups)
       (when (or transient--helpp transient--editp)
         (transient--insert-help))
-      (when (eq transient-mode-line-format 'line)
+      (when (and (eq transient-mode-line-format 'line)
+                 window-system)
         (insert (propertize "__" 'face 'transient-separator
                             'display '(space :height (1))))
         (insert (propertize "\n" 'face 'transient-separator 'line-height t)))