[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/transient c7ad1f01f4 080/366: transient--delete-window:
From: |
Jonas Bernoulli |
Subject: |
[elpa] externals/transient c7ad1f01f4 080/366: transient--delete-window: Protect against misconfiguration |
Date: |
Tue, 25 Jan 2022 18:54:29 -0500 (EST) |
branch: externals/transient
commit c7ad1f01f4ff9e5125bcec99dfb9c3dedadfc369
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
transient--delete-window: Protect against misconfiguration
Transient expects the popup buffer to be displayed in a new window.
If that is not the case, then it won't work properly and this commit
does not do anything to make it work properly anyway (because that
is not possible).
Regardless, the user should still be able to exit the transient state
even when things are broken like that, but doing so failed if the
transient popup was displayed in the only window because we ended up
trying to delete window, which is not allowed. Continue to try to
kill the transient window, but if that fails, then continue with the
rest of the exit procedure.
Re #34 #44.
---
lisp/transient.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/transient.el b/lisp/transient.el
index b77060d9eb..891740686f 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -1609,7 +1609,8 @@ EDIT may be non-nil."
(defun transient--delete-window ()
(when (window-live-p transient--window)
(let ((buf (window-buffer transient--window)))
- (delete-window transient--window)
+ (with-demoted-errors "Error while exiting transient: %S"
+ (delete-window transient--window))
(kill-buffer buf))))
(defun transient--export ()
- [elpa] externals/transient 7a7c3e15b6 065/366: transient-show-popup: Support even suppressing one-line summary, (continued)
- [elpa] externals/transient 7a7c3e15b6 065/366: transient-show-popup: Support even suppressing one-line summary, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient d7a1e81440 067/366: transient-show-popup: Update documentation, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 5a360bb206 090/366: Remove conflicting suffix when inserting new suffix, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 4ce1868e62 091/366: Fix replacing a suffix with another suffix bound to same key, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 52fb9a6c07 093/366: transient--insert-suffix: Cosmetics, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 4adc28538b 069/366: transient--window: Unset when exiting transient, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient af8d725d26 073/366: transient--original-window: New variable, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 4ef8229feb 082/366: transient--buffer-name: New variable, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 9fb3f797f1 103/366: Regenerate manual, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 7b62e01e72 064/366: transient-show-popup: Also show the key that invoked the prefix, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient c7ad1f01f4 080/366: transient--delete-window: Protect against misconfiguration,
Jonas Bernoulli <=
- [elpa] externals/transient b036789121 078/366: Move require form next to the others, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient f0a7a97d6b 083/366: Fix using set transient value, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 8bfa489644 095/366: Support inserting string pseudo suffixes, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient cbcfabeec6 105/366: manual: Fix some typos and minor language issues, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 450d0f869f 114/366: transient--insert-suffix: Fix use of binding defined in object, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient f820ccc6b9 119/366: transient-format-value: Support options with multiple values, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 7288a30126 123/366: Remove conflict with edebug, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient b0185a3ad6 125/366: transient--read-file-contents: Remove stray variable access, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 98ed4af766 128/366: Fix typo in doc-string, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 5f28a75609 134/366: Add htmlxref.cnf, Jonas Bernoulli, 2022/01/25