[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/transient 625683c9ea 029/366: transient--pre-exit: Don'
From: |
Jonas Bernoulli |
Subject: |
[elpa] externals/transient 625683c9ea 029/366: transient--pre-exit: Don't reselect original window |
Date: |
Tue, 25 Jan 2022 18:54:23 -0500 (EST) |
branch: externals/transient
commit 625683c9eab7fb53f65b27ffbe04afebcaae892a
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
transient--pre-exit: Don't reselect original window
Doing so would prevent the use of a transient to do window management.
It is also not necessary. If a suffix unintentionally selects another
window, then that is a bug; don't try to work around such bugs.
---
docs/CHANGELOG | 6 ++++++
lisp/transient.el | 4 +---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/docs/CHANGELOG b/docs/CHANGELOG
index 282545e91e..c593c0fd22 100644
--- a/docs/CHANGELOG
+++ b/docs/CHANGELOG
@@ -1,6 +1,12 @@
# -*- mode: org -*-
* v0.2.0 UNRELEASED
+- The window that was selected before the transient window was shown
+ is no longer re-selected before calling a suffix that exits the
+ transient. If a suffix changes the selected window unintentionally,
+ then that is a bug. This makes it possible to intentionally change
+ the window layout using transients.
+
- An infix is a special kind of suffix. Depending on context
"suffixes" means "suffixes (including infixes)" or "non-infix
suffixes". This is now mention in a few places where users might
diff --git a/lisp/transient.el b/lisp/transient.el
index 792ef9a028..1e176402d3 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -1438,9 +1438,7 @@ EDIT may be non-nil."
(defun transient--pre-exit ()
(transient--debug 'pre-exit)
- (let ((window (selected-window)))
- (lv-delete-window)
- (select-window window))
+ (transient--delete-window)
(transient--timer-cancel)
(transient--pop-keymap 'transient--transient-map)
(transient--pop-keymap 'transient--redisplay-map)
- [elpa] externals/transient 892bc840c0 072/366: transient--original-buffer: Set globally, (continued)
- [elpa] externals/transient 892bc840c0 072/366: transient--original-buffer: Set globally, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient fa3b7574bb 087/366: transient--layout-member: Use appropriate argument order, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 20c231e0ec 089/366: transient--layout-member-1: Refactor, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient cac657a03e 092/366: Support inserting/removing groups and doing it using coordinates, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 6236a4fd38 019/366: Bind ESC ESC ESC in all maps, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient e889030b0f 027/366: Quote a parenthesis in a doc-string, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 2033ac1ed9 031/366: transient-mode-line-format: New option, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 08b4778890 033/366: Make it trivial to use "q" to quit again, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 9429cb628a 035/366: transient-scroll-down: Fix pasto, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 7e45a57ec8 030/366: No longer depend on lv to display the transient buffer, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 625683c9ea 029/366: transient--pre-exit: Don't reselect original window,
Jonas Bernoulli <=
- [elpa] externals/transient a2dada29c8 034/366: manual: Add a FAQ, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient a2222d294c 038/366: transient-base-map: New parent of other shared keymaps, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient b1da0cab5d 040/366: Remove my personal key bindings, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient bbf81297c6 041/366: Prevent infix commands from being added to command-history, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient a6295fa7ee 042/366: Declare that prefix and suffix commands are for interactive use only, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 2872b4a661 045/366: transient-init-value: Define for transient-prefix, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient a47ae9499b 049/366: transient-{set, save}: Support exiting the transient, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 9e30038d2d 051/366: transient-set-level: Limit when it is called, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 544b3bb864 057/366: Support automatically disabling incompatible arguments, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 28aac32e82 058/366: Fix previous commit, Jonas Bernoulli, 2022/01/25