emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/transient 6a9b8a6bd4 037/366: Bind transient-scroll-{up


From: Jonas Bernoulli
Subject: [elpa] externals/transient 6a9b8a6bd4 037/366: Bind transient-scroll-{up, down} explicitly
Date: Tue, 25 Jan 2022 18:54:24 -0500 (EST)

branch: externals/transient
commit 6a9b8a6bd42074ab6ce58eb4504682b366a989f4
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    Bind transient-scroll-{up,down} explicitly
    
    Remapping `scroll-{up,down}-command' does not work.
---
 docs/CHANGELOG    |  6 +++++-
 lisp/transient.el | 18 ++++++++++++------
 2 files changed, 17 insertions(+), 7 deletions(-)

diff --git a/docs/CHANGELOG b/docs/CHANGELOG
index 71836707e8..55ef46891b 100644
--- a/docs/CHANGELOG
+++ b/docs/CHANGELOG
@@ -12,7 +12,11 @@
   be necessary to do that.  #17
 
 - Added new commands ~transient-scroll-up~ and ~transient-scroll-down~,
-  which scroll the transient window.  #17
+  which scroll the transient window.  ~C-v~ and ~M-v~ (and ~<next>~ and
+  ~<prior>~) are bound to these commands.  These keys were choosen they
+  are bound to scrolling commands in the global map too.  This made
+  it necessary to find a new binding for ~transient-show~, which ~C-t~ is
+  bound to now.  #17
 
 - The window that was selected before the transient window was shown
   is no longer re-selected before calling a suffix that exits the
diff --git a/lisp/transient.el b/lisp/transient.el
index 7676689d0f..f8449ea8ed 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -1110,8 +1110,10 @@ but unfortunately that does not exist (yet?)."
     (define-key map (kbd "C-q") 'transient-quit-all)
     (define-key map (kbd "C-z") 'transient-suspend)
     (define-key map (kbd "ESC ESC ESC") 'transient-quit-all)
-    (define-key map [remap scroll-up-command] 'transient-scroll-up)
-    (define-key map [remap scroll-down-command]'transient-scroll-down)
+    (define-key map (kbd "C-v") 'transient-scroll-up)
+    (define-key map (kbd "M-v") 'transient-scroll-down)
+    (define-key map [next]      'transient-scroll-up)
+    (define-key map [prior]     'transient-scroll-down)
     map)
   "Base keymap used by all transients.")
 
@@ -1124,8 +1126,10 @@ but unfortunately that does not exist (yet?)."
     (define-key map (kbd "C-q")   'transient-quit-all)
     (define-key map (kbd "C-z")   'transient-suspend)
     (define-key map (kbd "ESC ESC ESC") 'transient-quit-all)
-    (define-key map [remap scroll-up-command] 'transient-scroll-up)
-    (define-key map [remap scroll-down-command]'transient-scroll-down)
+    (define-key map (kbd "C-v") 'transient-scroll-up)
+    (define-key map (kbd "M-v") 'transient-scroll-down)
+    (define-key map [next]      'transient-scroll-up)
+    (define-key map [prior]     'transient-scroll-down)
     map)
   "Keymap that is active while a transient in is in \"edit mode\".")
 
@@ -1135,8 +1139,10 @@ but unfortunately that does not exist (yet?)."
     (define-key map (kbd "C-q") 'transient-quit-all)
     (define-key map (kbd "C-z") 'transient-suspend)
     (define-key map (kbd "ESC ESC ESC") 'transient-quit-all)
-    (define-key map [remap scroll-up-command] 'transient-scroll-up)
-    (define-key map [remap scroll-down-command]'transient-scroll-down)
+    (define-key map (kbd "C-v") 'transient-scroll-up)
+    (define-key map (kbd "M-v") 'transient-scroll-down)
+    (define-key map [next]      'transient-scroll-up)
+    (define-key map [prior]     'transient-scroll-down)
     map)
   "Keymap that is active while an incomplete key sequence is active.")
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]