emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/mct 552e8b07cc 2/5: Rework mct--one-column-p; document


From: ELPA Syncer
Subject: [elpa] externals/mct 552e8b07cc 2/5: Rework mct--one-column-p; document bug with it
Date: Fri, 21 Jan 2022 14:58:32 -0500 (EST)

branch: externals/mct
commit 552e8b07ccab0c19f8f690b0891f3a552911f9eb
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Rework mct--one-column-p; document bug with it
---
 mct.el | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/mct.el b/mct.el
index c9dd9469d9..17f465ea88 100644
--- a/mct.el
+++ b/mct.el
@@ -426,17 +426,20 @@ Apply APP by first setting up the minibuffer to work with 
Mct."
 ;; (declare-function prop-match-beginning "text-property-search" (cl-x))
 ;; (declare-function prop-match-end "text-property-search" (cl-x))
 
+
+
+;; FIXME 2022-01-21: The line highlight does not :extend for
+;; mct-region-mode when using the one-column style.
+
 ;; We need this to make things work on Emacs 27.
 (defun mct--one-column-p ()
   "Test if we have a one-column view available."
-  (cond
-   ;; FIXME 2022-01-19: Avoid duplication?
-   ((mct--region-p)
-    (and (eq mct-region-completions-format 'one-column)
-         (>= emacs-major-version 28)))
-   ((mct--minibuffer-p)
-    (and (eq mct-completions-format 'one-column)
-         (>= emacs-major-version 28)))))
+  (when (>= emacs-major-version 28)
+    (cond
+     ((mct--region-p)
+      (eq mct-region-completions-format 'one-column))
+     ((mct--minibuffer-p)
+      (eq mct-completions-format 'one-column)))))
 
 ;;;;; Focus minibuffer and/or show completions
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]