emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/dtache d744ff82b8 2/8: Only update size when a session


From: ELPA Syncer
Subject: [elpa] externals/dtache d744ff82b8 2/8: Only update size when a session becomes inactive
Date: Fri, 21 Jan 2022 10:57:29 -0500 (EST)

branch: externals/dtache
commit d744ff82b8d6eb29a838a586c0506772f41d6a20
Author: Niklas Eklund <niklas.eklund@posteo.net>
Commit: Niklas Eklund <niklas.eklund@posteo.net>

    Only update size when a session becomes inactive
---
 dtache.el           | 13 +++++--------
 test/dtache-test.el |  4 ++--
 2 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/dtache.el b/dtache.el
index 83b38b3c49..34f629df2f 100644
--- a/dtache.el
+++ b/dtache.el
@@ -853,12 +853,7 @@ Sessions running on  current host or localhost are 
updated."
          (progn
            (setf (dtache--session-time session)
                  (dtache--update-session-time session t))
-           (dtache--session-state-transition-update session)))
-        (t (progn
-             (setf (dtache--session-size session)
-                   (file-attribute-size (file-attributes
-                                         (dtache--session-file session 'log))))
-             (dtache--db-update-entry session)))))
+           (dtache--session-state-transition-update session)))))
 
 (defun dtache--session-file (session file &optional local)
   "Return the full path to SESSION's FILE.
@@ -1164,8 +1159,10 @@ session and trigger a state transition."
 
 (defun dtache--size-str (session)
   "Return the size of SESSION's output."
-  (file-size-human-readable
-   (dtache--session-size session)))
+  (if (eq 'active (dtache--session-state session))
+      ""
+      (file-size-human-readable
+       (dtache--session-size session))))
 
 (defun dtache--status-str (session)
   "Return string if SESSION has failed."
diff --git a/test/dtache-test.el b/test/dtache-test.el
index baadd2c034..2451f5459b 100644
--- a/test/dtache-test.el
+++ b/test/dtache-test.el
@@ -260,8 +260,8 @@
     (should (string= "May 08 08:49" (dtache--creation-str session)))))
 
 (ert-deftest dtache-test-size-str ()
-  (should (string= "100" (dtache--size-str (dtache--session-create :size 
100))))
-  (should (string= "1k" (dtache--size-str (dtache--session-create :size 
1024)))))
+  (should (string= "100" (dtache--size-str (dtache--session-create :size 100 
:state 'inactive))))
+  (should (string= "1k" (dtache--size-str (dtache--session-create :size 1024 
:state 'inactive)))))
 
 (ert-deftest dtache-test-status-str ()
   (should (string= "!" (dtache--status-str (dtache--session-create :status 
'failure))))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]