[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/dtache 914daabbb8 092/158: Fix regression for shell-com
From: |
ELPA Syncer |
Subject: |
[elpa] externals/dtache 914daabbb8 092/158: Fix regression for shell-command and compile |
Date: |
Wed, 19 Jan 2022 18:58:01 -0500 (EST) |
branch: externals/dtache
commit 914daabbb89683bc1059fc3776fdf45888c63370
Author: Niklas Eklund <niklas.eklund@posteo.net>
Commit: Niklas Eklund <niklas.eklund@posteo.net>
Fix regression for shell-command and compile
The approach with the start-process advice was too low level. It
caused problems on remote hosts. Needs some more work.
---
dtache-compile.el | 2 +-
dtache.el | 9 ++++++---
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/dtache-compile.el b/dtache-compile.el
index 7a9d7e908b..57cec6a57d 100644
--- a/dtache-compile.el
+++ b/dtache-compile.el
@@ -75,7 +75,7 @@ Optionally EDIT-COMMAND."
(cl-letf* ((name-function (lambda (_) buffer-name))
(dtache--current-session (or dtache--current-session
(dtache-create-session
command))))
- (apply compilation-start `(,command
+ (apply compilation-start `(,(dtache-dtach-command command t)
,(or mode 'dtache-compilation-mode)
,name-function
,highlight-regexp)))))
diff --git a/dtache.el b/dtache.el
index f1e0acafd6..628c03580c 100644
--- a/dtache.el
+++ b/dtache.el
@@ -452,11 +452,14 @@ Optionally SUPPRESS-OUTPUT."
(eq dtache-session-mode 'new)
(dtache--session-redirect-only
dtache--current-session))))
(dtache-session-mode 'new))
- (apply #'start-file-process-shell-command `("dtache" nil ,command))
+ (progn (setq dtache-enabled nil)
+ (apply #'start-file-process-shell-command
+ `("dtache" nil ,(dtache-dtach-command
dtache--current-session t))))
(cl-letf* ((dtache-session-mode 'create)
((symbol-function #'set-process-sentinel) #'ignore)
(buffer "*Dtache Shell Command*"))
- (funcall #'async-shell-command command buffer)
+ (setq dtache-enabled nil)
+ (funcall #'async-shell-command (dtache-dtach-command
dtache--current-session t) buffer)
(with-current-buffer buffer (setq dtache--buffer-session
dtache--current-session))))))
(defun dtache-update-sessions ()
@@ -556,7 +559,7 @@ Optionally make the path LOCAL to host."
(seq-do #'dtache-start-session-monitor))
;; Advices
- (advice-add #'start-process :around #'dtache-start-process-advice)
+ ;; (advice-add #'start-process :around #'dtache-start-process-advice)
;; Add `dtache-shell-mode'
(add-hook 'shell-mode-hook #'dtache-shell-mode)))
- [elpa] externals/dtache c8a99aed35 123/158: Add version to the dtache database, (continued)
- [elpa] externals/dtache c8a99aed35 123/158: Add version to the dtache database, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 4fa1c9e8a2 134/158: Simplify call to dtache--dtach-arg, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 3942dc6326 135/158: Remove unnecessary checks for dtache-session-mode, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 3aa5babca5 139/158: Update table formatting, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache ee8f3efa26 144/158: Version 0.3, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache d0ec7b9777 156/158: Add support for filenotify on macOS, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache aca73c1e60 152/158: Address issues from melpazoid in melpa/melpa7867, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 81d7fbcdca 082/158: Integrate dtache with start-process, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 125f100b20 087/158: Regroup variable section, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 5f12c82fed 090/158: Revert back dtache-eshell, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 914daabbb8 092/158: Fix regression for shell-command and compile,
ELPA Syncer <=
- [elpa] externals/dtache 3029774325 093/158: Update README, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache b779e7071b 104/158: Improve dtache-detach-dwim, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 051968ec99 111/158: Update dtache extension headers, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache e1ebc053bb 116/158: Avoid saving history file for dtache-shell-command, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 561f67d075 121/158: Make remove entry delete session log, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache b285ac5a0f 128/158: Update version schema for sessions, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 0e0e8c6394 126/158: Update docstring, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 31d7ffd5f7 131/158: Rename redirect-only to attachable, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 3da7747fa1 130/158: Update Versions/Contributions/Credits, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 2337bb132f 132/158: Update mode symbols, ELPA Syncer, 2022/01/19