[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/dtache d574161815 042/158: Simplify buffer handling
From: |
ELPA Syncer |
Subject: |
[elpa] externals/dtache d574161815 042/158: Simplify buffer handling |
Date: |
Wed, 19 Jan 2022 18:57:44 -0500 (EST) |
branch: externals/dtache
commit d57416181530f82ca8ef8e7ccb753a46f544b975
Author: Niklas Eklund <niklas.eklund@posteo.net>
Commit: Niklas Eklund <niklas.eklund@posteo.net>
Simplify buffer handling
Now when dtache supports diff between two sessions there is little
usage to be able to open session outputs in different buffers. Also
remove distinction between dtache compile and dtache output.
---
dtache.el | 53 +++++++++++++++++++++++++----------------------------
1 file changed, 25 insertions(+), 28 deletions(-)
diff --git a/dtache.el b/dtache.el
index 00d5cf0142..384638ef34 100644
--- a/dtache.el
+++ b/dtache.el
@@ -228,9 +228,7 @@
(list (if (eq major-mode 'dtache-sessions-mode)
(tabulated-list-get-id)
(dtache-select-session))))
- (let ((buffer-name
- (format "*dtache-compile-%s*"
- (dtache--session-short-id session)))
+ (let ((buffer-name "*dtache-session-output*")
(file
(dtache-session-file session 'log))
(tramp-verbose 1))
@@ -322,9 +320,7 @@
(list (if (eq major-mode 'dtache-sessions-mode)
(tabulated-list-get-id)
(dtache-select-session))))
- (let* ((buffer-name
- (format "*dtache-output-%s*"
- (dtache--session-short-id session)))
+ (let* ((buffer-name "*dtache-session-output*")
(file-path
(dtache-session-file session 'log))
(tramp-verbose 1))
@@ -364,12 +360,16 @@
(list
(dtache-select-session)
(dtache-select-session)))
- (dtache--create-diff-buffer session1)
- (dtache--create-diff-buffer session2)
- (let ((buffer1 (format "*dtache-diff-%s*"
- (dtache--session-short-id session1)))
- (buffer2 (format "*dtache-diff-%s*"
- (dtache--session-short-id session2))))
+ (let ((buffer1 "*dtache-session-output-1*")
+ (buffer2 "*dtache-session-output-2*"))
+ (with-current-buffer (get-buffer-create buffer1)
+ (erase-buffer)
+ (insert (dtache--session-header session1))
+ (insert (dtache-session-output session1)))
+ (with-current-buffer (get-buffer-create buffer2)
+ (erase-buffer)
+ (insert (dtache--session-header session2))
+ (insert (dtache-session-output session2)))
(ediff-buffers buffer1 buffer2)))
;;;###autoload
@@ -752,22 +752,19 @@ Sessions running on current host or localhost are
updated."
(setq dtache--remote-session-timer
(run-with-timer 10 60 #'dtache-update-remote-sessions))))
-(defun dtache--create-diff-buffer (session)
- "Create a diff buffer for SESSION."
- (let ((buffer-name
- (format "*dtache-diff-%s*"
- (dtache--session-short-id session))))
- (with-current-buffer (get-buffer-create buffer-name)
- (erase-buffer)
- (insert (format "Command: %s\n" (dtache--session-command session)))
- (insert (format "Working directory: %s\n" (dtache--working-dir-str
session)))
- (insert (format "Status: %s\n" (dtache--session-status session)))
- (insert (format "Created at: %s\n" (dtache--creation-str session)))
- (insert (format "Id: %s\n" (dtache--session-id session)))
- (insert (format "Metadata: %s\n" (dtache--metadata-str session)))
- (insert (format "Duration: %s\n" (dtache--duration-str session)))
- (insert "\n")
- (insert (dtache-session-output session)))))
+(defun dtache--session-header (session)
+ "Return header for SESSION."
+ (mapconcat
+ #'identity
+ `(,(format "Command: %s" (dtache--session-command session))
+ ,(format "Working directory: %s" (dtache--working-dir-str session))
+ ,(format "Status: %s" (dtache--session-status session))
+ ,(format "Created at: %s" (dtache--creation-str session))
+ ,(format "Id: %s" (dtache--session-id session))
+ ,(format "Metadata: %s" (dtache--metadata-str session))
+ ,(format "Duration: %s" (dtache--duration-str session))
+ "")
+ "\n"))
;;;;; Database
- [elpa] externals/dtache 182ab7ccc6 064/158: Add integration with consult, (continued)
- [elpa] externals/dtache 182ab7ccc6 064/158: Add integration with consult, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache ea6d8ae426 068/158: Add missing autoloads, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache e2efe466e0 076/158: Improve error handling with dtache-valid-session, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 79f1d905a9 078/158: Add example of how to enhance a command with dtach, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache dae6db33db 083/158: Fix various minor problems, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 52e839ff4a 007/158: Update README with links, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 7e8727f3a2 020/158: Add TODO to investigate unknown inactive sessions, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache b94baaeecd 021/158: Fix bug in setup notification, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 763246bffe 026/158: Remove explicit dependency on dtache-env, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 087e8f4c73 019/158: Update README, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache d574161815 042/158: Simplify buffer handling,
ELPA Syncer <=
- [elpa] externals/dtache 1878cefb2f 038/158: Remove embark dependency, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 3c61776c7f 014/158: Fix dtache initialization, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 7c07950642 043/158: Implement better encapsulation of database, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 42569d1c5f 036/158: Update broken tests, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache ddf9bb6ade 039/158: Add action map example, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache c70c9366a5 028/158: Update test to test with/without dtache-env, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache d5aa90356a 029/158: Add CHANGELOG to project, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 4751b4d812 046/158: Implement a general timer function, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache 1bc60af5a0 040/158: Update changelog and readme, ELPA Syncer, 2022/01/19
- [elpa] externals/dtache d32b5752d6 034/158: Implement new deduplication strategy, ELPA Syncer, 2022/01/19