[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/org-drill a949ece724 165/251: Remove more dynamic scoping
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/org-drill a949ece724 165/251: Remove more dynamic scoping errors |
Date: |
Mon, 17 Jan 2022 18:59:12 -0500 (EST) |
branch: elpa/org-drill
commit a949ece7244b1a4557e53f546450ee98a35de520
Author: Phillip Lord <phillip.lord@russet.org.uk>
Commit: Phillip Lord <phillip.lord@russet.org.uk>
Remove more dynamic scoping errors
---
org-drill.el | 30 ++++++++++++++++++++----------
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/org-drill.el b/org-drill.el
index 162b4fca73..fc881e47e9 100644
--- a/org-drill.el
+++ b/org-drill.el
@@ -3590,7 +3590,7 @@ returns its return value."
(let ((spelln-language lang))
(spelln-integer-in-words n)))
-(defun org-drill-present-translate-number (session)
+(defun org-drill-present-translate-number (_session)
(let ((num-min (read (org-entry-get (point) "DRILL_NUMBER_MIN")))
(num-max (read (org-entry-get (point) "DRILL_NUMBER_MAX")))
(language (read (org-entry-get (point) "DRILL_LANGUAGE" t)))
@@ -3659,45 +3659,55 @@ returns its return value."
(defun org-drill-present-spanish-verb (session)
- (let ((prompt nil)
- (reveal-headings nil))
+ (let ((prompt nil))
(with-hidden-comments
(with-hidden-cloze-hints
(with-hidden-cloze-text
(cl-case (cl-random 6)
+ ;; PWL 2018-06-22
+ ;; As far as I can tell, neither prompt nor reveal-headings
+ ;; do anything here. They never seem to appear anyway. But
+ ;; this might be because I broke things when cleaning up the
+ ;; dynamic binding.
(0
(org-drill-hide-all-subheadings-except '("Infinitive"))
(setq prompt
(concat "Translate this Spanish verb, and conjugate it "
"for the *present* tense.")
- reveal-headings '("English" "Present Tense" "Notes")))
+ ;;reveal-headings '("English" "Present Tense" "Notes")
+ ))
(1
(org-drill-hide-all-subheadings-except '("English"))
(setq prompt (concat "For the *present* tense, conjugate the "
"Spanish translation of this English verb.")
- reveal-headings '("Infinitive" "Present Tense" "Notes")))
+ ;;reveal-headings '("Infinitive" "Present Tense" "Notes")
+ ))
(2
(org-drill-hide-all-subheadings-except '("Infinitive"))
(setq prompt (concat "Translate this Spanish verb, and "
"conjugate it for the *past* tense.")
- reveal-headings '("English" "Past Tense" "Notes")))
+ ;;reveal-headings '("English" "Past Tense" "Notes")
+ ))
(3
(org-drill-hide-all-subheadings-except '("English"))
(setq prompt (concat "For the *past* tense, conjugate the "
"Spanish translation of this English verb.")
- reveal-headings '("Infinitive" "Past Tense" "Notes")))
+ ;;reveal-headings '("Infinitive" "Past Tense" "Notes")
+ ))
(4
(org-drill-hide-all-subheadings-except '("Infinitive"))
(setq prompt (concat "Translate this Spanish verb, and "
"conjugate it for the *future perfect* tense.")
- reveal-headings '("English" "Future Perfect Tense" "Notes")))
+ ;;reveal-headings '("English" "Future Perfect Tense" "Notes")
+ ))
(5
(org-drill-hide-all-subheadings-except '("English"))
(setq prompt (concat "For the *future perfect* tense, conjugate the "
"Spanish translation of this English verb.")
- reveal-headings '("Infinitive" "Future Perfect Tense"
"Notes"))))
+ ;;reveal-headings '("Infinitive" "Future Perfect Tense"
"Notes")
+ )))
(org-cycle-hide-drawers 'all)
- (prog1 (org-drill-presentation-prompt session)
+ (prog1 (org-drill-presentation-prompt session prompt)
(org-drill-hide-subheadings-if 'org-drill-entry-p)))))))
- [nongnu] elpa/org-drill be851b9eb4 142/251: Refactor robot testing, (continued)
- [nongnu] elpa/org-drill be851b9eb4 142/251: Refactor robot testing, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill 1470bdb487 131/251: Remove org-drill-new-entries, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill 50885fbeea 146/251: Refactor robot testing to allow multiple tests, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill c58cb90ff0 123/251: Update gitignore, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill 644b0a5cbc 126/251: Remove org-learn as a separate package, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill 9aa3e98ea0 130/251: Remove org-drill-start-time, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill b161277f82 156/251: Replace more non-namespaced commands, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill 61fe47deb8 152/251: Replace drill-answer, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill 02b507b839 151/251: Add leitner robot test and fix, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill 6533b73246 164/251: Support changing small sleep on command line, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill a949ece724 165/251: Remove more dynamic scoping errors,
ELPA Syncer <=
- [nongnu] elpa/org-drill 82c2ec8b1f 189/251: Replace call to gensym with cl-gensym, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill 4300ef9d4c 168/251: Fix broken form in org-drill-resume, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill 58b353993c 158/251: Complete namespace cleanliness, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill 77480ae0a2 181/251: Remove arguments from presentation-prompt, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill 5a405f5d08 188/251: Fix session call in org-drill-sm-or-leitner, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill c44ca7447b 199/251: Document explainer, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill 5b6bb5445c 157/251: Fix broken test, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill b2b7c3f625 175/251: Remove dynamic scoping, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill 7a7f9370fa 159/251: Fix byte compilation errors, ELPA Syncer, 2022/01/17
- [nongnu] elpa/org-drill d3695d66f3 173/251: Fix call to session, ELPA Syncer, 2022/01/17