emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/eglot 74144db942: ; Re-enable some tests in CI


From: ELPA Syncer
Subject: [elpa] externals/eglot 74144db942: ; Re-enable some tests in CI
Date: Sat, 15 Jan 2022 05:57:27 -0500 (EST)

branch: externals/eglot
commit 74144db942301e748329a9dd8b29f66ca35d4b5c
Author: Stefan Kangas <stefan@marxist.se>
Commit: Stefan Kangas <stefan@marxist.se>

    ; Re-enable some tests in CI
    
    * .github/workflows/test.yml (jobs): Add some Python dependencies.
    * eglot-tests.el (basic-diagnostics, eglot-multiline-eldoc)
    (eglot-single-line-eldoc): Re-enable tests on CI.
    (eglot--tests-force-full-eldoc): Increase sleep to 0.5 seconds.
---
 .github/workflows/test.yml |  2 +-
 eglot-tests.el             | 14 ++++----------
 2 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 69f665c010..f5dc8d3c52 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -35,7 +35,7 @@ jobs:
 
     - name: Install other depedencies
       run: |
-           pip3 install python-language-server autopep8
+           pip3 install python-language-server autopep8 rope pycodestyle 
pyflakes pydocstyle mccabe pylint
            sudo apt-get install clangd-9
 
     - name: Build eglot
diff --git a/eglot-tests.el b/eglot-tests.el
index 6c2ab7bdd6..96364c6147 100644
--- a/eglot-tests.el
+++ b/eglot-tests.el
@@ -409,9 +409,7 @@ Pass TIMEOUT to `eglot--with-timeout'."
 
 (ert-deftest basic-diagnostics ()
   "Test basic diagnostics."
-  (skip-unless (and (executable-find "pyls")
-                    ;; FIXME: Doesn't work in Github CI.
-                    (not (getenv "CI"))))
+  (skip-unless (executable-find "pyls"))
   (eglot--with-fixture
       `(("diag-project" .
                                         ; colon missing after True
@@ -467,7 +465,7 @@ Pass TIMEOUT to `eglot--with-timeout'."
                        (let ((bs (buffer-string)))
                          (unless (zerop (length bs)) bs))))
    when retval return retval
-   do (sit-for 0.1)
+   do (sit-for 0.5)
    finally (error "eglot--tests-force-full-eldoc didn't deliver")))
 
 (ert-deftest rls-hover-after-edit ()
@@ -625,9 +623,7 @@ def foobazquuz(d, e, f): pass
 (ert-deftest eglot-multiline-eldoc ()
   "Test if suitable amount of lines of hover info are shown."
   :expected-result (if (getenv "TRAVIS_TESTING") :failed :passed)
-  (skip-unless (and (executable-find "pyls")
-                    ;; FIXME: Doesn't work in Github CI.
-                    (not (getenv "CI"))))
+  (skip-unless (executable-find "pyls"))
   (eglot--with-fixture
       `(("project" . (("hover-first.py" . "from datetime import datetime"))))
     (with-current-buffer
@@ -642,9 +638,7 @@ def foobazquuz(d, e, f): pass
 
 (ert-deftest eglot-single-line-eldoc ()
   "Test if suitable amount of lines of hover info are shown."
-  (skip-unless (and (executable-find "pyls")
-                    ;; FIXME: Doesn't work in Github CI.
-                    (not (getenv "CI"))))
+  (skip-unless (executable-find "pyls"))
   (eglot--with-fixture
       `(("project" . (("hover-first.py" . "from datetime import datetime"))))
     (with-current-buffer



reply via email to

[Prev in Thread] Current Thread [Next in Thread]