[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/transient bf29731a72 13/38: transient--post-command: Do
From: |
Jonas Bernoulli |
Subject: |
[elpa] externals/transient bf29731a72 13/38: transient--post-command: Don't pop and push equal redisplay maps |
Date: |
Tue, 11 Jan 2022 05:37:44 -0500 (EST) |
branch: externals/transient
commit bf29731a721118ec1c1ed94f45e57ca67815550a
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
transient--post-command: Don't pop and push equal redisplay maps
`set-transient-map' arranges for the exit function not to be called
if another transient map was added later. While we don't use that
function ourselves, this feature still backfires when we replace the
redisplay map, causing e.g. `mouse-drag-track's transient map to be
left in place when it should be removed.
---
lisp/transient.el | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lisp/transient.el b/lisp/transient.el
index 386d4d2ad3..478e32aaef 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -2100,9 +2100,12 @@ value. Otherwise return CHILDREN as is."
(transient--post-exit))
((eq this-command (oref transient--prefix command)))
(t
- (transient--pop-keymap 'transient--redisplay-map)
- (setq transient--redisplay-map (transient--make-redisplay-map))
- (transient--push-keymap 'transient--redisplay-map)
+ (let ((old transient--redisplay-map)
+ (new (transient--make-redisplay-map)))
+ (unless (equal old new)
+ (transient--pop-keymap 'transient--redisplay-map)
+ (setq transient--redisplay-map new)
+ (transient--push-keymap 'transient--redisplay-map)))
(transient--redisplay)))))
(defun transient--post-exit ()
- [elpa] externals/transient 777a84d26b 20/38: manual: Document all options, (continued)
- [elpa] externals/transient 777a84d26b 20/38: manual: Document all options, Jonas Bernoulli, 2022/01/11
- [elpa] externals/transient 51585b8dd7 25/38: transient-reset: New command, Jonas Bernoulli, 2022/01/11
- [elpa] externals/transient 6c9ae1f46a 27/38: manual: Replace some inaccurate information, Jonas Bernoulli, 2022/01/11
- [elpa] externals/transient de5a325616 30/38: Re-align debug declarations, Jonas Bernoulli, 2022/01/11
- [elpa] externals/transient 12097b72d7 32/38: manual: Regenerate, Jonas Bernoulli, 2022/01/11
- [elpa] externals/transient 45241225cf 36/38: transient-common-commands: Evaluate lambdas, Jonas Bernoulli, 2022/01/11
- [elpa] externals/transient cda6a12042 23/38: transient-align-variable-pitch: New option, Jonas Bernoulli, 2022/01/11
- [elpa] externals/transient 4c31a10113 31/38: Remove unnecessary with-eval-after-load, Jonas Bernoulli, 2022/01/11
- [elpa] externals/transient 8b1f8dcc51 35/38: transient--minibuffer-depth: Must always be a number, Jonas Bernoulli, 2022/01/11
- [elpa] externals/transient 9412f26175 37/38: manual: Use more @itemx, Jonas Bernoulli, 2022/01/11
- [elpa] externals/transient bf29731a72 13/38: transient--post-command: Don't pop and push equal redisplay maps,
Jonas Bernoulli <=
- [elpa] externals/transient 22e032ae65 24/38: Move obsolete variable declaration, Jonas Bernoulli, 2022/01/11
- [elpa] externals/transient 6d721f7490 29/38: Don't use convert-standard-filename when defining path variables, Jonas Bernoulli, 2022/01/11
- [elpa] externals/transient ecb815bcae 34/38: transient--abort-commands: Add keyboard-escape-quit, Jonas Bernoulli, 2022/01/11
- [elpa] externals/transient 3de8d9b256 38/38: manual: Fix list item, Jonas Bernoulli, 2022/01/11